-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alley-Oop Theme #8124
base: trunk
Are you sure you want to change the base?
Add Alley-Oop Theme #8124
Conversation
Preview changesI've detected changes to the following themes in this PR: AlleyOop. I will update this comment with the latest preview links as you push more changes to this PR. |
This theme needs to be run through theme check plugin, it's throwing a bunch of warnings. Most notably the theme dir name doesn't match the theme slug. |
I fixed the warnings. This theme had dotcom specific code that I haven't seen in any of our other themes. Is this a premium theme by any chance? This theme also has unsplash images, that are triggering the theme check plugin too |
I've noticed that, too. With that, this theme should only be on dotcom.
There is no mention of it in the post. pNEWy-hMY-p2. It's probably inherited from the base theme he used to build it. Could you tell me where they are? I can clean it up. |
I'll clean up this theme. |
Theme-Check resultsalleyoop: No changes required ✅.❎ REQUIRED
💡 RECOMMENDED (2)
ℹ️ INFO (1)
|
OK, I've edited quite a bit of the theme code. Again, we don't submit this theme to Dotorg as it uses Unsplash images. Is it good to go? |
Changes proposed in this Pull Request:
Related issue(s):