Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alley-Oop Theme #8124

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

Add Alley-Oop Theme #8124

wants to merge 9 commits into from

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

Related issue(s):

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Preview changes

I've detected changes to the following themes in this PR: AlleyOop.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@scruffian scruffian added the Ready to launch Add this label if this is the first PR for a new theme label Sep 13, 2024
@alaczek
Copy link
Contributor

alaczek commented Sep 19, 2024

This theme needs to be run through theme check plugin, it's throwing a bunch of warnings. Most notably the theme dir name doesn't match the theme slug.

@MaggieCabrera
Copy link
Contributor

I fixed the warnings. This theme had dotcom specific code that I haven't seen in any of our other themes. Is this a premium theme by any chance?

This theme also has unsplash images, that are triggering the theme check plugin too

@iamtakashi
Copy link
Contributor

iamtakashi commented Sep 19, 2024

This theme also has unsplash images

I've noticed that, too. With that, this theme should only be on dotcom.

This theme had dotcom specific code that I haven't seen in any of our other themes. Is this a premium theme by any chance?

There is no mention of it in the post. pNEWy-hMY-p2. It's probably inherited from the base theme he used to build it. Could you tell me where they are? I can clean it up.

@iamtakashi iamtakashi self-assigned this Sep 20, 2024
@iamtakashi
Copy link
Contributor

I'll clean up this theme.

Copy link
Contributor

Theme-Check results

alleyoop: No changes required ✅.

❎ REQUIRED

  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
💡 RECOMMENDED (2)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
ℹ️ INFO (1)
  • Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs. The domain found is alleyoop.

@iamtakashi
Copy link
Contributor

OK, I've edited quite a bit of the theme code. Again, we don't submit this theme to Dotorg as it uses Unsplash images. Is it good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants