Allow "-" in version numbers.

Automattic · Dec 28, 2022 · e700490 · e700490
1 parent 9add4f0
commit e700490
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/output-security.php b/output-security.php
@@ -19,7 +19,7 @@ function vipgoci_output_sanitize_version_number(
 	string $version_number
 ) :string {
 	return preg_replace(
-		'/[^a-zA-Z0-9\.]/',
+		'/[^a-zA-Z0-9\.\-]/',
 		'',
 		$version_number
 	);

diff --git a/tests/unit/OutputSecuritySanitizeVersionNumberTest.php b/tests/unit/OutputSecuritySanitizeVersionNumberTest.php
@@ -33,11 +33,11 @@ protected function setUp() :void {
 	 */
 	public function testSanitizeVersionNumber(): void {
 		$sanitized_number = vipgoci_output_sanitize_version_number(
-			PHP_EOL . ' 1.50.30.3b,    ' . "\t" . PHP_EOL
+			PHP_EOL . ' 1.50.30.3b,  - 5b  ' . "\t" . PHP_EOL
 		);
 
 		$this->assertSame(
-			'1.50.30.3b',
+			'1.50.30.3b-5b',
 			$sanitized_number
 		);
 	}