Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Status API support #169

Merged
merged 24 commits into from
May 14, 2021
Merged

Add Status API support #169

merged 24 commits into from
May 14, 2021

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented May 10, 2021

TODO:

  • Refine github-commit-status.php
  • Refine vipgoci_github_status_create()
  • Implement a maximum execution time support
  • --help message
  • Add unit-tests
  • Update README
  • Changelog entry
  • Public documentation changes
  • Check automated unit-tests

@gudmdharalds gudmdharalds self-assigned this May 10, 2021
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

⚠️ 1 warning


This bot provides automated PHP Linting and PHPCS scanning, read more here.

github-commit-status.php Show resolved Hide resolved
@gudmdharalds gudmdharalds added this to the 1.0.5 milestone May 11, 2021
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 2 errors


This bot provides automated PHP Linting and PHPCS scanning, read more here.

tests/GitHubStatusCreateTest.php Outdated Show resolved Hide resolved
tests/GitHubStatusCreateTest.php Outdated Show resolved Hide resolved
@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot dismissed their stale review May 11, 2021 17:58

Dismissing review as all inline comments are obsolete by now

@gudmdharalds gudmdharalds merged commit dad9933 into master May 14, 2021
@gudmdharalds gudmdharalds deleted the add-status-api-1 branch May 21, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants