Use new GitHub Teams API #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariskataoka
added a commit
that referenced
this pull request
Oct 22, 2021
ariskataoka
added a commit
that referenced
this pull request
Nov 10, 2021
* Changelog for version 1.0.9 * Adding version 1.0.9 * Add #204 to the 1.0.9 changelog * Add #209 to the 1.0.9 changelog * Add #217 to the 1.0.9 changelog * Remove #205 changelog It's been postponed and won't be part of the 1.0.9 version. * Add #208 to the 1.0.9 changelog * Add #214 to the 1.0.9 changelog * Add release date to the change log Co-authored-by: Ariana Kataoka <[email protected]> Co-authored-by: Ariana Kataoka <[email protected]>
wpcomvip-vipgoci-bot
previously requested changes
Feb 9, 2022
There was a problem hiding this comment.
phpcs scanning turned up:
🚫 11 errors
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
| @@ -6,8 +6,9 @@ | |||
|
|
|||
| final class GitHubTeamMembersTest extends TestCase { | |||
| var $options = array( | |||
| 'github-token' => null, | |||
| 'team-id' => null, | |||
| 'github-token' => null, | |||
There was a problem hiding this comment.
wpcomvip-vipgoci-bot
dismissed
their stale review
Dismissing review as all inline comments are obsolete by now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use new GitHub Teams API endpoint instead of a deprecated Teams API endpoint.
This closes #128.
TODO:
org-nameparameter as neededPHPDoccomments for new or updated functions.