Use exec() instead of shell_exec(), use result code #264

gudmdharalds · 2022-03-28T19:27:40Z

Use exec() instead of shell_exec(), as exec() will provide result code of program run. Use the result code to evaluate if the program returned with status provided by caller. This allows us to accurately detect if utilities are run successfully or not.

TODO:

Add/update unit-tests (if needed)
- Update test integration/StatisticsRuntimeMeasureExecWithRetryTest.php (for vipgoci_runtime_measure_exec_with_retry()).
Check automated unit-tests
Changelog entry (for VIP) [ Changelog for version 1.2.3 #262 ]

wpcomvip-vipgoci-bot

phpcs scanning turned up:

⚠️ 1 warning

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.2` PHP runtime version for vip-go-ci: `8.1.4` PHP runtime for linting: PHP 8.1: `8.1.4` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` PHP runtime version for SVG scanner: `7.4.28` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

git-repo.php

… fails.

wpcomvip-vipgoci-bot

phpcs scanning turned up:

🚫 1 error

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.2` PHP runtime version for vip-go-ci: `8.1.4` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` PHP runtime version for SVG scanner: `7.4.28` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `false` SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

statistics.php

wpcomvip-vipgoci-bot · 2022-03-31T11:58:02Z

Scanning latest commit did not yield any new issues. Please have a look at older feedback still existing (commit-ID: 50b73d4)

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.2` PHP runtime version for vip-go-ci: `8.1.4` PHP runtime for linting: PHP 8.1: `8.1.4` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` PHP runtime version for SVG scanner: `7.4.28` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

gudmdharalds added 8 commits March 28, 2022 16:00

Altering utility execution function so to use exec(), and more.

4f603b2

Update usage of vipgoci_runtime_measure_exec_with_retry()

7c46e07

Update usage of vipgoci_runtime_measure_exec_with_retry()

2a7b743

Update usage of vipgoci_runtime_measure_exec_with_retry()

b2687b1

Update usage of vipgoci_runtime_measure_exec_with_retry()

131c7b2

Update usage of vipgoci_runtime_measure_exec_with_retry()

6b0865f

Update usage of vipgoci_runtime_measure_exec_with_retry()

c08fcb7

Update usage of vipgoci_runtime_measure_exec_with_retry()

e45f06d

gudmdharalds added this to the 1.2.3 milestone Mar 28, 2022

gudmdharalds self-assigned this Mar 28, 2022

wpcomvip-vipgoci-bot reviewed Mar 28, 2022

View reviewed changes

git-repo.php Outdated Show resolved Hide resolved

gudmdharalds and others added 2 commits March 28, 2022 19:30

Fix spacing.

160b9a8

Merge branch 'main' into update-exec-function

d46b7c1

gudmdharalds changed the title ~~Use exec() instead of shell_exec(), use return code~~ Use exec() instead of shell_exec(), use result code Mar 28, 2022

gudmdharalds added 9 commits March 28, 2022 19:49

Renaming variable.

c13983e

Renaming variables.

e3970c8

Renaming variable.

3d1e3f0

Renaming variables.

d34f507

Renaming variables.

aa341e1

Renaming class to fit new name of function.

f82f789

Test for command returning empty output; test for command that always…

bbbadb6

… fails.

Provide output even if command status code is unexpected.

23d03e1

Redefine variable type.

69adabe

wpcomvip-vipgoci-bot requested changes Mar 29, 2022

View reviewed changes

statistics.php Show resolved Hide resolved

gudmdharalds and others added 3 commits March 29, 2022 19:11

Update comment; test getting standard error output.

dc5ec1d

Add helper script.

afb8702

Merge branch 'main' into update-exec-function

f296f48

gudmdharalds added [Type] Enhancement [Pri] High labels Mar 30, 2022

gudmdharalds mentioned this pull request Mar 30, 2022

Update two integration tests relating to git functionality #267

Merged

7 tasks

Merge branch 'main' into update-exec-function

50b73d4

gudmdharalds merged commit 53c6f24 into main Mar 31, 2022

gudmdharalds deleted the update-exec-function branch March 31, 2022 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use exec() instead of shell_exec(), use result code #264

Use exec() instead of shell_exec(), use result code #264

gudmdharalds commented Mar 28, 2022 •

edited

Loading

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot commented Mar 31, 2022

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

Use exec() instead of shell_exec(), use result code #264

Use exec() instead of shell_exec(), use result code #264

Conversation

gudmdharalds commented Mar 28, 2022 • edited Loading

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot commented Mar 31, 2022

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

gudmdharalds commented Mar 28, 2022 •

edited

Loading

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)