Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB8-11121: Prevent enabling debug mode on local env for logged out users #5341

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aswasif007
Copy link
Contributor

@aswasif007 aswasif007 commented Mar 18, 2024

Description

We are updating the code to prevent debug mode from enabling automatically on local env for logged out users.

Changelog Description

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@aswasif007 aswasif007 requested a review from a team as a code owner March 18, 2024 04:23
@aswasif007 aswasif007 changed the title Prevent enabling debug mode on local env BB8-11121: Prevent enabling debug mode on local env Mar 18, 2024
@aswasif007
Copy link
Contributor Author

I am not sure if this has other implications. @Automattic/vip-platform-cantina please advise!

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.58%. Comparing base (9709732) to head (ada81e0).

Files Patch % Lines
000-debug/debug-mode.php 33.33% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5341      +/-   ##
=============================================
+ Coverage      29.57%   29.58%   +0.01%     
  Complexity      4780     4780              
=============================================
  Files            282      282              
  Lines          20600    20593       -7     
=============================================
+ Hits            6092     6093       +1     
+ Misses         14508    14500       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rebeccahum
Copy link
Contributor

@aswasif007 Per the BB8 comments, we shouldn't be removing this entirely locally, but only forcing it for users logged in locally I think.

Copy link
Contributor

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

@rebeccahum rebeccahum force-pushed the bb8-11121/fix/debug-mode-issue branch from 74614bb to ada81e0 Compare July 10, 2024 18:22
Copy link

sonarcloud bot commented Jul 10, 2024

@rebeccahum rebeccahum changed the title BB8-11121: Prevent enabling debug mode on local env BB8-11121: Prevent enabling debug mode on local env for logged out users Jul 10, 2024
Copy link
Contributor

@rinatkhaziev rinatkhaziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs further consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants