-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): memory usage in filter_wp_read_image_metadata()
#5554
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5554 +/- ##
=============================================
+ Coverage 29.41% 29.43% +0.01%
Complexity 4764 4764
=============================================
Files 281 281
Lines 20544 20532 -12
=============================================
Hits 6043 6043
+ Misses 14501 14489 -12 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Folded in my branch with dynamic timeouts on the download path, it's an extra call to VIP FS and probably needs some more defensive code and testing :) |
Quality Gate passedIssues Measures |
This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved. |
Keep open, please. |
Description
Reduce memory usage in
VIP_Filesystem::filter_wp_read_image_metadata()
by usingcopy()
instead offile_get_contents()
/file_put_contents()
.The symptoms are:
Changelog Description
Fixed
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test
Upload a large file (its size should exceed the memory available to PHP) before and after this patch.