-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Remote Data Blocks integration #5644
Closed
mehmoodak
wants to merge
17
commits into
cafe-919/update-IntegrationVipConfig-class-to-read-files-in-generic-way
from
adds-composable-blocks-integration
Closed
Adds Remote Data Blocks integration #5644
mehmoodak
wants to merge
17
commits into
cafe-919/update-IntegrationVipConfig-class-to-read-files-in-generic-way
from
adds-composable-blocks-integration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-in-generic-way' into adds-composable-blocks-integration
mehmoodak
force-pushed
the
cafe-919/update-IntegrationVipConfig-class-to-read-files-in-generic-way
branch
3 times, most recently
from
June 16, 2024 19:04
c5586c6
to
4653616
Compare
mehmoodak
changed the title
Adds integration of VIP Composable Blocks
Adds VIP Composable Blocks as integration
Jun 17, 2024
…s-in-generic-way' into adds-composable-blocks-integration
mehmoodak
commented
Jun 17, 2024
mehmoodak
changed the title
Adds VIP Composable Blocks as integration
Adds VIP Composable Blocks integration
Jun 17, 2024
chriszarate
reviewed
Jun 17, 2024
chriszarate
reviewed
Jun 17, 2024
…s-in-generic-way' into adds-composable-blocks-integration
Quality Gate passedIssues Measures |
…s-in-generic-way' into adds-composable-blocks-integration
mehmoodak
force-pushed
the
adds-composable-blocks-integration
branch
from
August 15, 2024 09:59
c57129c
to
f927e13
Compare
mehmoodak
force-pushed
the
adds-composable-blocks-integration
branch
from
August 15, 2024 10:00
f927e13
to
d9dca7e
Compare
mehmoodak
force-pushed
the
adds-composable-blocks-integration
branch
from
August 20, 2024 05:03
86dc38e
to
7c1e889
Compare
Quality Gate passedIssues Measures |
mehmoodak
changed the title
Adds VIP Composable Blocks integration
Adds Remote Data Blocks integration
Aug 20, 2024
rebeccahum
requested changes
Aug 21, 2024
8 tasks
rebeccahum
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
Remote Data Blocks
integration. This integration is dependent on data sources which is handled viadata_source_integrations
property.Changelog Description
Added
Pre-review checklist
Pre-deploy checklist
Steps to Test
Checkout this PR
Run the vip site locally using
vip dev-env start --slug [YOUR_SLUG]
(if no env is available then create it)Create integration config files inside
php
container and place configs (we have to do it manually because as of nowvip dev-env
doesn't have support to auto create this folder/file while creating new envs)docker exec -it [CONTAINER_NAME] /bin/sh
mkdir /wp/config/integrations-config
touch /wp/config/integrations-config/[SLUG]-123-config.php
and adds following content (Replace slug with anything)touch /wp/config/integrations-config/[SLUG]-456-config.php
and adds following contentRestart vip dev-env to apply changes in these config files.
Use
vip_integration_composable_blocks_config
filter to make sure that expected data is returning.Apart from enabling the plugin via VIP config, customer can also enables it by placing
\Automattic\VIP\Integrations\activate( 'remote-data-blocks' );
inplugin-loader.php
so please test this also and verify the configs.