Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype 50x response interceptor #5766

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rinatkhaziev
Copy link
Contributor

Description

Changelog Description

Added

Removed

Fixed

Changed

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

Copy link

sonarcloud bot commented Aug 1, 2024

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.56%. Comparing base (6124f87) to head (d8fc2e3).
Report is 122 commits behind head on develop.

Files with missing lines Patch % Lines
5xx-interceptor.php 70.58% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5766      +/-   ##
=============================================
+ Coverage      29.51%   29.56%   +0.05%     
  Complexity      4779     4779              
=============================================
  Files            282      283       +1     
  Lines          20587    20592       +5     
=============================================
+ Hits            6077     6089      +12     
+ Misses         14510    14503       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant