Use recommended order currency API for multicurrency subscription renewal | switch | resubscribe #4228

haszari · 2022-05-04T23:43:55Z

Changes proposed in this Pull Request

Custom order tables are coming to WooCommerce core.

To prepare for that, we need to move away from using low-level APIs to access post meta for orders.

This PR updates the multicurrency WC Subscriptions integration to use the more robust and clearer get_currency() API. Previously the code used get_post_meta, which is not recommended, and could break in future when stores migrate to using custom order tables.

Testing instructions

This change should not change any behaviour. As I understand it, there's no buggy behaviour here unless the store has migrated to custom tables (which is not yet available/shipped yet).

For my testing, I added logging to confirm the relevant lines of code were run, and logged the currency code (to ensure it was correct). All the flows below trigger the code when preparing an order for cart/checkout.

In all tests, the currency code should be the shopper's currency, not the store default.

The test instructions below are all a very simple happy path. Reviewers please suggest and test alternative flows that might be impacted.

Prerequisite - set up payments, subscription product, and multi-currency

Onboard WooCommerce Payments and install and activate WC Subscriptions.
Publish a subscription product:

Go to WooCommerce admin dashboard, click Products > Add New in sidebar.
Type a product name e.g. Coffee Subscription.
Scroll down to Product data box and select Simple subscription from Product type dropdown.
Enter a price e.g. 20 in Subscription price ($) field.
Select a renewal term, e.g. every day.

Set up multi currency. Needs to be activated in Woo settings and WCPay, and a currency switcher displayed for customer on store front end.

In WooCommerce admin dashboard, go to Payments > Settings.
Click Multi-currency tab.
Click Add currencies and add one or more additional currencies, e.g. Yen, Euro etc.
Scroll down to Store settings.
Ensure Add a currency switcher to the Storefront theme on breadcrumb section..
Click Save changes.

You should now have a subscription product in your store that shoppers can purchase in their chosen currency.

Test multicurrency subscription renewal

Complete prerequisite setup above.
Purchase a subscription in customer currency (not store default).
Go to subscription in admin dashboard.
Select action Create pending renewal order, click Update.
As customer, go to My account, click Subscriptions, scroll down to Related orders.
Click Pay. Confirm correct (customer) currency is displayed in checkout.

Test multicurrency subscription switch

Complete prerequisite setup above.
In WooCommerce > Settings > Subscriptions, enable both Allow switching options. (See below pic)
Set up subscription products that subscriber can switch between (aka upgrade/downgrade). Easiest way is setting up a variable subscription product with 2 or more levels (e.g. Basic | Pro attribute). Can also switch between grouped products.
- Click on Products > Add new in WooCommerce admin dashboard sidebar.
- Type a product name e.g. Coffee Subscription.
- Scroll down to Product data box and select Variable subscription from Product type dropdown.
- Click Attributes.
- Click Add next to Custom product attribute dropdown.
- Type Level in Name: box.
- Type Basic | Regular | Pro in Value(s) box.
- Check Used for variations checkbox.
- Click Save attributes.
- Click Variations.
- Select Create variations from all attributes from dropdown and click Go. Click OK in Are you sure… modal to continue. Click OK in 3 variations added modal.
- Click disclosure triangle (on right) in first variation and add a price in Subscription price ($) field.
- Repeat for all variations.
- Click Save changes.
- Scroll up to top of page and click Publish on right to publish the variable subscription product.
As shopper, subscribe to one of the variation products.
Go to My account, click Subscriptions.
Click switchable subscription to view details/options.
Click Upgrade or Downgrade. Select a variation to switch to and click Switch subscription. Confirm correct (customer) currency is displayed in checkout.

Test multicurrency resubscribe

Complete prerequisite setup above.
Purchase a subscription in customer currency (not store default).
Go to subscription in admin dashboard.
Click Cancel for the subscription. Subscription should now be cancelled, so shopper can resubscribe.
As customer, go to My account, click Subscriptions
Click Resubscribe. Refer to docs for details - resubscribing is a kind of renewal.
Confirm correct (customer) currency is displayed in checkout.

Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
Covered with tests (or have a good reason not to test in description ☝️)
Tested on mobile (or does not apply)

Post merge

Link to testing instructions from release testing doc following these instructions : Test multicurrency subscription renewal, switch and re-subscribe

- previously used raw `get_post_meta()` - this is no longer recommended, and could break on stores using (forthcoming) custom order tables

haszari · 2022-05-04T23:47:35Z

Note: I skipped the checks when committing this. There was a problem with phpcs, I'm not sure if it's related to these changes.

Here's the error:

�[1mFILE: ...cludes/multi-currency/Compatibility/WooCommerceSubscriptions.php�[0m
----------------------------------------------------------------------
�[1mFOUND 1 ERROR AFFECTING 1 LINE�[0m
----------------------------------------------------------------------
 1 | �[31mERROR�[0m | �[1mAn error occurred during processing; checking has been
   |       | aborted. The error message was: trim(): Passing null to
   |       | parameter #1 ($string) of type string is deprecated in
   |       | /Users/rua/_automattic/transact-dev/woocommerce-payments/vendor/wp-coding-standards/wpcs/WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php
   |       | on line 280�[0m (Internal.Exception)
-------------------------------------------------------------------

…der-meta-api

mattallan · 2022-05-08T23:35:05Z

I skipped the checks when committing this. There was a problem with phpcs, I'm not sure if it's related to these changes.

Here's the error:

Interesting! That error might be caused by your node version. Try running nvm use while in the woocommerce-payments directory

mattallan · 2022-05-08T23:39:18Z

includes/multi-currency/Compatibility/WooCommerceSubscriptions.php

@@ -148,7 +148,7 @@ public function override_selected_currency( $return ) {

 		$subscription_renewal = $this->cart_contains_renewal();
 		if ( $subscription_renewal ) {
-			return get_post_meta( $subscription_renewal['subscription_renewal']['renewal_order_id'], '_order_currency', true );
+			return $subscription_renewal['subscription_renewal']['renewal_order_id']->get_currency();


$subscription_renewal['subscription_renewal']['renewal_order_id'] is an order ID/integer which doesn't have a get_currency() method.

We'll have to get the order object first, i.e.:

$order = wc_get_order( $subscription_renewal['subscription_renewal']['renewal_order_id'] ); return $order ? $order->get_currency() : false;

D'oh! Of course! Fixed in 20ea6b0

Note in all these I'm returning $return instead of hard-coded "false". Should be equivalent, but feels more in-keeping with the function comment.

Side note – I don't really understand what this function is doing. The early return when passed $return = [currency] param makes no sense to me; if passing a valid currency code, the function can't "override"?

woocommerce-payments/includes/multi-currency/Compatibility/WooCommerceSubscriptions.php

Lines 136 to 147 in e01a19c

/**

* Checks to see if the if the selected currency needs to be overridden.

*

* @param mixed $return Default is false, but could be three letter currency code.

*

* @return mixed Three letter currency code or false if not.

*/

public function override_selected_currency( $return ) {

// If it's not false, return it.

if ( $return ) {

return $return;

}

We can dig into that when testing, I'm still figuring out how to test this 🤔

mattallan · 2022-05-08T23:40:40Z

includes/multi-currency/Compatibility/WooCommerceSubscriptions.php

@@ -159,12 +159,12 @@ public function override_selected_currency( $return ) {
 		$switch_cart_items = $this->get_subscription_switch_cart_items();
 		if ( 0 < count( $switch_cart_items ) ) {
 			$switch_cart_item = array_shift( $switch_cart_items );
-			return get_post_meta( $switch_cart_item['subscription_switch']['subscription_id'], '_order_currency', true );
+			return $switch_cart_item['subscription_switch']['subscription_id']->get_currency();


Similarly for these lines as well, however since we're using the subscription ID we should get a subscription object using:
wcs_get_subscription( $subscription_resubscribe['subscription_resubscribe']['subscription_id'] )

Then call get_currency() on that object 😃

haszari · 2022-05-09T04:26:39Z

I skipped the checks when committing this. There was a problem with phpcs, I'm not sure if it's related to these changes.

Interesting! That error might be caused by your node version. Try running nvm use while in the woocommerce-payments directory

Just tried that. Now on npm 12, still getting same error. Skipped checks again :)

- fix logic issue in previous commit

…der-meta-api

…rrency-order-meta-api' into fix/4152-subscribe-renew-multicurrency-order-meta-api

haszari · 2022-06-14T01:41:30Z

This is ready for another review & test.

Changes since previous reviews:

Testing instructions added (and I've confirmed these do trigger the relevant code).
Fixed an issue with resubscribe case - c433f4e .

Unit tests?

I'm keen to add unit tests - IMO this is a good candidate for unit tests. If we add unit test coverage for all code touched by custom tables changes, we can re-run those tests later with custom table set up (etc). @mattallan @brucealdridge keen to hear your thoughts 💭

Could add unit tests as part of this PR or as follow up.

…der-meta-api

haszari · 2022-06-16T00:05:37Z

Could add unit tests as part of this PR or as follow up.

We already have tests for this! And one is failing – working on fixing it.

haszari · 2022-06-16T01:17:14Z

I think the unit tests are failing because the new implementation depends on various functions / state that isn't mocked:

wc_get_order()
$order->get_currency()
wcs_get_subscription()

How can I mock those global functions - is this something we do in our unit tests?

Here are the options as I see it…

Mock these functions. I think this is the approach used most often in WCPay tests, keen to hear what people think.
Refactor the code that uses the globals into method(s) on WooCommerceSubscriptions, then mock those methods. That feels like cheating to me, and would undermine the usefulness of the test. Core parts of the logic I'm adding would be fenced off and mocked instead of tested.
Mock up the state/data more holistically - and mock less functions. More of a WordPress test approach, aka integration testing. I'd create and store a real order using regular APIs (in setup/teardown) and link to real renewal and subscription objects as needed for what I want to test.

What's the best approach to get these tests working and providing value long term?

jrodger · 2022-06-16T09:41:24Z

And one is failing – working on fixing it.

I'm also seeing 2 tests erroring out due to an infinite loop, but that might just be on my environment. Worth checking once the failing one is fixed though!

I think the unit tests are failing because the new implementation depends on various functions / state that isn't mocked

wc_get_order() and wcs_get_subscription() are examples of global functions that are tricky to mock. For $order->get_currency() depending on the context we can usually treat this as a plain data object, so no need to mock it, just pass around a real order object and methods like this will work fine.

Here are the options as I see it

Agreed, I think this covers all the options!

Mock these functions. I think this is the approach used most often in WCPay tests, keen to hear what people think.

Do you have any examples where that has been done for global functions like wc_get_order()? I've had a quick look and can't find anything. Generally speaking though, for non-global dependencies, we'd look to mock them. I used to refer to this as testing the "outer seam" (i.e. passing parameters in) and the "inner seam" (asserting that dependencies were called as expected). I have stopped using this analogy because I can't find it written down anywhere and I'm worried someone was making a joke at my expense 😂 .

Since these are global functions I wouldn't recommend mocking them, unless we can find some precedence elsewhere in the codebase

Refactor the code that uses the globals into method(s) on WooCommerceSubscriptions, then mock those methods.

You could do this, but I'd suggest instead encapsulating the global functions in a class (or classes) that could be injected into WooCommerceSubscriptions. That helper class could then be mocked. This doesn't feel like cheating to me, you're just splitting up different responsibilities into different classes. Having said that, I can't find an example of us doing this.

The closest I can find is this call to process_payment_for_order where we gather everything we need from global functions and pass them into this unit testable method as parameters. It's almost the inverse of adding methods to make the global calls, but achieves the same aim.

Mock up the state/data more holistically - and mock less functions.

IMO this is the best approach here, and it matches what's being done in the unit test already. Instead of creating post meta data we'd just create an order. We're using a helper method to create test orders in places like this. Do you see any unique challenges to this approach when it comes to subscriptions? Perhaps extending that WooCommerce Core helper and adding some methods for creating subscription orders would be an option?

You're correct when you say this is more of an integration test, while I'd like to see us breaking more of this plugin up into unit testable chunks, WordPress wasn't written with unit testing in mind so it's perfectly acceptable to follow a more integration testy approach IMO.

- Make a real order with non-default currency - integration test style. - Enhance mock_wcs_cart_contains_renewal so test can customise product and renewal order ids. - Mock the real order instead of hacking post meta (legacy implementation detail). - Fix up all uses of mock_wcs_cart_contains_renewal() for new signature.

- Rename / update comment to clarify test scope. - Mock up a real order (aka subscription) with custom currency. - Mock that order idea in $_GET request params.

haszari · 2022-06-17T01:34:11Z

[recommended unit testing approach]
Mock up the state/data more holistically - and mock less functions.
create test orders
aka integration testing / WP testing

Update! I've fixed the first two tests to use a real order, and tweaked mock_wcs_cart_contains_renewal() to allow use of real order (and updated tests that use it).

These two tests are now working:

test_override_selected_currency_return_currency_code_when_renewal_in_cart()
test_override_selected_currency_return_currency_code_for_switch_request() (renamed)

Next steps

I'm still working on the others. To get them working I need to mock up more cart state, e.g. add a switch item to the cart to test this code:

woocommerce-payments/includes/multi-currency/Compatibility/WooCommerceSubscriptions.php

Lines 160 to 165 in 37bb933

    
           $switch_cart_items = $this->get_subscription_switch_cart_items(); 
        
           if ( 0 < count( $switch_cart_items ) ) { 
        
           	$switch_cart_item = array_shift( $switch_cart_items ); 
        
           	$switch_subscription = wcs_get_subscription( $switch_cart_item['subscription_switch']['subscription_id'] ); 
        
           	return $switch_subscription ? $switch_subscription->get_currency() : $return; 
        
           }

@mattallan can you point me to WCS APIs for setting up a switch cart item?

// get_subscription_switch_cart_items() is a wrapper for wcs_get_order_type_cart_items()
// How does a `switch` cart item get added to cart – can I call those functions in my test to set up the relevant state?
wcs_get_order_type_cart_items( 'switch' );

mattallan · 2022-06-21T00:46:00Z

can you point me to WCS APIs for setting up a switch cart item?

We don't have a simple API to setup a switch cart item in a unit test environment, however, I would take a look at WC_Subscriptions_Switcher::set_switch_details_in_cart() to see how we do it.

Here's is the cart item data we use to determine whether an item is a switch:

$cart_item['subscription_switch'] = array(
	'subscription_id'        => $subscription->get_id(),
	'item_id'                => absint( $_GET['item'] ),
	'next_payment_timestamp' => $next_payment_timestamp,
	'upgraded_or_downgraded' => '',
);

You could just manually set this data to mock a switch cart item.

Alternatively, you could port over something like this WC Subscriptions unit test helper (get_switch_cart_item_instance() which we use to get a switch cart item object

- use WC_Order for mock subscription - mock subscription and cart APIs as needed

- parameterise wcs_get_order_type_cart_items so can use real order id - mock sub (order) and wcs_get_subscription to return mocked sub - it's fine right

haszari · 2022-06-23T02:54:11Z

Unit tests are now passing

I used WC_Order to simulate a subscription. This means we don't need to mock WC_Subscription->get_currency().
Other than that, I'm using the existing mocks to mock up what the test expects the tested function to call (i.e. APIs).
I parameterised various mock utils so I could pass in a "real" subscription ID, e.g. see mock_wcs_get_order_type_cart_items().

- ERROR: UndefinedFunction $switch_subscription = wcs_get_subscription( $switch_cart_item['subscription_switch']['subscription_id'] );

haszari · 2022-06-23T04:04:29Z

I think I'm getting psalm errors now, due to using wcs_get_subscription. Example error:

152
ERROR: UndefinedFunction - �
[153](https://github.com/Automattic/woocommerce-payments/runs/7016129242?check_suite_focus=true#step:5:154)
			$switch_subscription = wcs_get_subscription( $switch_cart_item['subscription_switch']['subscription_id'] );
[154](https://github.com/Automattic/woocommerce-payments/runs/7016129242?check_suite_focus=true#step:5:155)
[155](https://github.com/Automattic/woocommerce-payments/runs/7016129242?check_suite_focus=true#step:5:156)
[156](https://github.com/Automattic/woocommerce-payments/runs/7016129242?check_suite_focus=true#step:5:157)
ERROR: UndefinedFunction - �
[157](https://github.com/Automattic/woocommerce-payments/runs/7016129242?check_suite_focus=true#step:5:158)
			$switch_subscription = wcs_get_subscription( $subscription_resubscribe['subscription_resubscribe']['subscription_id'] );
[158](https://github.com/Automattic/woocommerce-payments/runs/7016129242?check_suite_focus=true#step:5:159)

Added a wrapper method here 1dda55e but that seems to break the tests?

There were 2 errors:

1) WCPay_Multi_Currency_WooCommerceSubscriptions_Tests::test_override_selected_currency_return_currency_code_when_switch_in_cart
TypeError: Return value of WCPay\MultiCurrency\Compatibility\WooCommerceSubscriptions::get_subscription() must be of the type array, object returned

/var/www/html/wp-content/plugins/woocommerce-payments/includes/multi-currency/Compatibility/WooCommerceSubscriptions.php:309
/var/www/html/wp-content/plugins/woocommerce-payments/includes/multi-currency/Compatibility/WooCommerceSubscriptions.php:163
/var/www/html/wp-content/plugins/woocommerce-payments/tests/unit/multi-currency/compatibility/test-class-woocommerce-subscriptions.php:323
phpvfscomposer:///var/www/html/wp-content/plugins/woocommerce-payments/vendor/phpunit/phpunit/phpunit:97

2) WCPay_Multi_Currency_WooCommerceSubscriptions_Tests::test_override_selected_currency_return_currency_code_when_resubscribe_in_cart
TypeError: Return value of WCPay\MultiCurrency\Compatibility\WooCommerceSubscriptions::get_subscription() must be of the type array, object returned

/var/www/html/wp-content/plugins/woocommerce-payments/includes/multi-currency/Compatibility/WooCommerceSubscriptions.php:309
/var/www/html/wp-content/plugins/woocommerce-payments/includes/multi-currency/Compatibility/WooCommerceSubscriptions.php:169
/var/www/html/wp-content/plugins/woocommerce-payments/tests/unit/multi-currency/compatibility/test-class-woocommerce-subscriptions.php:348
phpvfscomposer:///var/www/html/wp-content/plugins/woocommerce-payments/vendor/phpunit/phpunit/phpunit:97

Getting closer!

…der-meta-api

+ clarify true type in docblock comment

…rrency-order-meta-api' into fix/4152-subscribe-renew-multicurrency-order-meta-api

haszari · 2022-06-27T03:34:44Z

Checks have passed! Ready for a final review @mattallan and/or @Jinksi - this has had one review but the test code has not been reviewed.

haszari · 2022-06-28T03:57:39Z

Testing instructions added here: Test multicurrency subscription renewal, switch and re-subscribe

FYI @Jinksi - slightly more detailed test instructions for your reviewing pleasure 😁

FYI @mattallan - can you check over these instructions to make sure they are effective for testing these changes, and complete enough for GlobalStep (i.e. did I miss a step!) - thanks 🙌

…der-meta-api

Jinksi

This LGTM @haszari 🎉 🙌

Unit tests pass and cover changes to the override_selected_currency() function.

I followed the release testing instructions and found it all to be working as expected:

Prerequisites
Test multicurrency subscription renewal
Test multicurrency subscription switch
Test multicurrency resubscribe

Note there was a discrepancy in Test multicurrency subscription switch step 7, and the Resubscribe button was not available to click. I suggest this change:

- 7. Click `Resubscribe`. Confirm correct (customer) currency is displayed in checkout.
+ 7. Click `Upgrade or Downgrade`. Select a variation to switch to and click `Switch subscription`. Confirm correct (customer) currency is displayed in checkout.

includes/multi-currency/Compatibility/WooCommerceSubscriptions.php

haszari · 2022-06-29T00:55:55Z

Thanks for the thorough & helpful review & testing @Jinksi !

Note there was a discrepancy in Test multicurrency subscription switch step 7, and the Resubscribe button was not available to click. I suggest this change:

I've made that change and also fleshed out details for creating a switchable product (variable subscription product.

…rrency-order-meta-api' into fix/4152-subscribe-renew-multicurrency-order-meta-api

use recommended WC_Order::get_currency() for getting renewal currency:

e154bb3

- previously used raw `get_post_meta()` - this is no longer recommended, and could break on stores using (forthcoming) custom order tables

haszari self-assigned this May 4, 2022

haszari added the pr: in progress label May 4, 2022

add changelog

14eb4e3

Merge branch 'develop' into fix/4152-subscribe-renew-multicurrency-or…

2a78530

…der-meta-api

haszari mentioned this pull request May 4, 2022

Update code calling get_post_meta() with an Order IDs and use CRUD methods instead #4152

Closed

1 task

haszari changed the title ~~Use high-level order currency API for multicurrency subscription renewal | switch | resubscribe~~ Use recommended order currency API for multicurrency subscription renewal | switch | resubscribe May 4, 2022

Merge branch 'develop' into fix/4152-subscribe-renew-multicurrency-or…

e01a19c

…der-meta-api

mattallan reviewed May 8, 2022

View reviewed changes

convert id to order/subscription object before calling get_currency:

20ea6b0

- fix logic issue in previous commit

brucealdridge self-requested a review May 16, 2022 23:10

haszari and others added 3 commits June 14, 2022 13:25

Merge branch 'develop' into fix/4152-subscribe-renew-multicurrency-or…

dfbde74

…der-meta-api

fix fatal error on resubscribe – get subscription from ID

c433f4e

Merge remote-tracking branch 'origin/fix/4152-subscribe-renew-multicu…

bc31724

…rrency-order-meta-api' into fix/4152-subscribe-renew-multicurrency-order-meta-api

haszari requested a review from a team June 14, 2022 01:37

Merge branch 'develop' into fix/4152-subscribe-renew-multicurrency-or…

23ec842

…der-meta-api

Rua Haszard added 2 commits June 17, 2022 12:19

Repair multicurrency sub switch unit test:

37bb933

- Rename / update comment to clarify test scope. - Mock up a real order (aka subscription) with custom currency. - Mock that order idea in $_GET request params.

Rua Haszard added 2 commits June 23, 2022 14:29

repair multicurrency subs switch in cart unit test:

053bf3c

- use WC_Order for mock subscription - mock subscription and cart APIs as needed

refactor mock_wcs_get_order_type_cart_items so can pass a real order id

f45d6b9

Rua Haszard added 2 commits June 23, 2022 14:41

repair multicurrency sub resubscribe unit test:

3d97600

- parameterise wcs_get_order_type_cart_items so can use real order id - mock sub (order) and wcs_get_subscription to return mocked sub - it's fine right

remove a bunch of extraneous whitespace / php linter fixes

4a1cfc8

Rua Haszard added 2 commits June 23, 2022 14:54

remove extraneous whitespace / php linter fixes

02cf94e

add local wrapper for wcs_get_subscription() – attempt psalm fix:

1dda55e

- ERROR: UndefinedFunction $switch_subscription = wcs_get_subscription( $switch_cart_item['subscription_switch']['subscription_id'] );

haszari and others added 6 commits June 23, 2022 16:04

Merge branch 'develop' into fix/4152-subscribe-renew-multicurrency-or…

b21922a

…der-meta-api

fix mismatched param name in docblock for get_subscription wrapper

73780a4

Merge branch 'develop' into fix/4152-subscribe-renew-multicurrency-or…

d3eeea8

…der-meta-api

remove incorrect return type (array) from get_subscription test helper +

76365db

+ clarify true type in docblock comment

Merge remote-tracking branch 'origin/fix/4152-subscribe-renew-multicu…

9290953

…rrency-order-meta-api' into fix/4152-subscribe-renew-multicurrency-order-meta-api

remove whitespace offending the linter

6c139f6

Merge branch 'develop' into fix/4152-subscribe-renew-multicurrency-or…

91cfcc0

…der-meta-api

Jinksi self-requested a review June 28, 2022 05:07

Jinksi approved these changes Jun 28, 2022

View reviewed changes

includes/multi-currency/Compatibility/WooCommerceSubscriptions.php Outdated Show resolved Hide resolved

rename subscription variable – it's resubscribe not switch

a5ccf31

Merge remote-tracking branch 'origin/fix/4152-subscribe-renew-multicu…

98afc22

…rrency-order-meta-api' into fix/4152-subscribe-renew-multicurrency-order-meta-api

haszari merged commit 0756cce into develop Jun 29, 2022

haszari deleted the fix/4152-subscribe-renew-multicurrency-order-meta-api branch June 29, 2022 02:33

This was referenced Jan 20, 2023

[HPOS] Replace call to get_post_meta in MultiCurrency\Compatibility\WooCommerceSubscriptions with HPOS-compatible order CRUD method. #5424

Closed

Use order currency API when overriding currency for a subscription switch to support HPOS #5432

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use recommended order currency API for multicurrency subscription renewal | switch | resubscribe #4228

Use recommended order currency API for multicurrency subscription renewal | switch | resubscribe #4228

haszari commented May 4, 2022 •

edited

Loading

haszari commented May 4, 2022

mattallan commented May 8, 2022

mattallan May 8, 2022

haszari May 9, 2022

haszari May 9, 2022 •

edited

Loading

mattallan May 8, 2022

haszari commented May 9, 2022

haszari commented Jun 14, 2022

haszari commented Jun 16, 2022

haszari commented Jun 16, 2022 •

edited

Loading

jrodger commented Jun 16, 2022

haszari commented Jun 17, 2022 •

edited

Loading

mattallan commented Jun 21, 2022

haszari commented Jun 23, 2022

haszari commented Jun 23, 2022

haszari commented Jun 27, 2022

haszari commented Jun 28, 2022

Jinksi left a comment

haszari commented Jun 29, 2022

	/**
	* Checks to see if the if the selected currency needs to be overridden.
	*
	* @param mixed $return Default is false, but could be three letter currency code.
	*
	* @return mixed Three letter currency code or false if not.
	*/
	public function override_selected_currency( $return ) {
	// If it's not false, return it.
	if ( $return ) {
	return $return;
	}

Use recommended order currency API for multicurrency subscription renewal | switch | resubscribe #4228

Use recommended order currency API for multicurrency subscription renewal | switch | resubscribe #4228

Conversation

haszari commented May 4, 2022 • edited Loading

Changes proposed in this Pull Request

Testing instructions

Prerequisite - set up payments, subscription product, and multi-currency

Test multicurrency subscription renewal

Test multicurrency subscription switch

Test multicurrency resubscribe

haszari commented May 4, 2022

mattallan commented May 8, 2022

mattallan May 8, 2022

Choose a reason for hiding this comment

haszari May 9, 2022

Choose a reason for hiding this comment

haszari May 9, 2022 • edited Loading

Choose a reason for hiding this comment

mattallan May 8, 2022

Choose a reason for hiding this comment

haszari commented May 9, 2022

haszari commented Jun 14, 2022

Unit tests?

haszari commented Jun 16, 2022

haszari commented Jun 16, 2022 • edited Loading

jrodger commented Jun 16, 2022

haszari commented Jun 17, 2022 • edited Loading

Next steps

mattallan commented Jun 21, 2022

haszari commented Jun 23, 2022

Unit tests are now passing

haszari commented Jun 23, 2022

haszari commented Jun 27, 2022

haszari commented Jun 28, 2022

Jinksi left a comment

Choose a reason for hiding this comment

haszari commented Jun 29, 2022

haszari commented May 4, 2022 •

edited

Loading

haszari May 9, 2022 •

edited

Loading

haszari commented Jun 16, 2022 •

edited

Loading

haszari commented Jun 17, 2022 •

edited

Loading