Framework: Redirect to Login page if logged out

When you hit a valid route as a logged-out user, we should send you to the login page with a redirect back to the page you were trying to access. This is how all wp-admin links in core WP works.

There have been fixes for individual pages (eg #24687 ) but this should be handled at the framework level. We have an email campaign using the Simple Payments Guided Tour #24627 and it freezes at a blank screen for a logged-out user.

What this change does is to do a redirect for a valid section with the `enableLoggedOut` property set to true to the login screen with a redirect. A future PR could probably remove all bespoke uses of `import { redirectLoggedOut } from 'controller'` as well since this should supersede it.

client/boot/common.js

@@ -108,6 +108,10 @@ const loggedOutMiddleware = currentUser => {
 
 	page( '*', ( context, next ) => {
 		if ( isValidSection( context.path ) ) {
+			// redirect to login page if we're not on it already
+			if ( ! startsWith( context.path, '/log-in' ) ) {
+				return page.redirect( '/log-in/?redirect_to=' + encodeURIComponent( context.path ) );
+			}
 			next();
 		}
 	} );

client/wordpress-com.js

@@ -188,6 +188,7 @@ const sections = [
 		module: 'my-sites/stats',
 		secondary: true,
 		group: 'sites',
+		enableLoggedOut: true,
 	},
 	{
 		name: 'checklist',