Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Embed: Remove WordPress embed #28326

Closed
rachelmcr opened this issue Oct 30, 2018 · 7 comments
Closed

Gutenberg: Embed: Remove WordPress embed #28326

rachelmcr opened this issue Oct 30, 2018 · 7 comments
Assignees
Labels
Calypsoify [Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Normal [Type] Bug wp-admin

Comments

@rachelmcr
Copy link
Member

rachelmcr commented Oct 30, 2018

Describe the bug

The WordPress embed block is available on WordPress.com, but trying to add a WordPress embed always results in an error:

Sorry, we could not embed that content.

On the front end, a plain link to the WordPress post appears.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a Gutenberg-enabled WordPress.com site.
  2. Start a new Gutenberg post.
  3. Add a WordPress embed block.
  4. Paste a link to a WordPress post and click the Embed button.
  5. See an error in the editor.
  6. Preview the post and see the plain link to the post.

Expected behavior

The WordPress embed block should not show up since it isn't supported on WordPress.com. Let's make sure to disable this in all wpcom environments.

Screenshots

screenshot 2018-10-30 16 08 01

Desktop (please complete the following information):

  • OS: macOS 10.14
  • Browser Chrome 70.0.3538.77
@mkaz mkaz transferred this issue from another repository Nov 6, 2018
@mkaz mkaz changed the title Embed: WordPress embed not supported on WP.com Gutenberg: Embed: WordPress embed not supported on WP.com Nov 6, 2018
@arunsathiya arunsathiya added [Type] Bug [Goal] Gutenberg Working towards full integration with Gutenberg wp-admin labels Dec 13, 2018
@arunsathiya
Copy link
Contributor

Noting that I am still able to reproduce this, and it happens only on Calypsoified Gutenberg. On Gutenlypso, I am seeing a blank, white space instead - logged this here #29388

@alisterscott
Copy link
Contributor

We've never been able to embed WordPress content for WordPress.com simple sites due to security concerns - even in the classic editor when pasting an oEmbed URL.

Perhaps we can just remove the block from appearing?

@rachelmcr
Copy link
Member Author

Perhaps we can just remove the block from appearing?

Agreed, that's what I expected:

The WordPress embed block should not show up since it isn't supported on WordPress.com.

@gwwar gwwar added this to the Gutenberg Embeds milestone Jan 8, 2019
@gwwar gwwar changed the title Gutenberg: Embed: WordPress embed not supported on WP.com Gutenberg: Embed: Remove WordPress embed Jan 8, 2019
@zdenys
Copy link
Contributor

zdenys commented Mar 21, 2019

Discovered this while I was going through adding all available Blocks into a post. It seems that the block is going to be removed eventually, right?

@mmtr mmtr self-assigned this Mar 22, 2019
@mmtr
Copy link
Member

mmtr commented Mar 22, 2019

Removal proposed in D25893-code

@retrofox
Copy link
Contributor

It seems that the block is going to be removed eventually, right?

right

@mmtr
Copy link
Member

mmtr commented Mar 27, 2019

The WordPress embed block should no longer be available after landing D25893-code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Calypsoify [Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Normal [Type] Bug wp-admin
Projects
None yet
Development

No branches or pull requests

8 participants