You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a good idea to remove our version and use the one shipped by the agnostic package. That way, we'd have a single source of truth and something that the community maintains, essentially one less point of maintenance for us.
Checklist
In @wordpress/base-styles, extract the long-content-fade mixin to its own file so we can import it exclusively
Remove the version from Calypso and import the long-content-fade file inside client/assets/stylesheets/shared/mixins/_mixins.scss
Check that all usages of long-content-fade did not introduce regressions, including the places where we're not defining the $color variable, which has a different default value in the mixin definition
Is it really necessary to change our upstream dependency? What's the harm of importing a bunch of SCSS mixins if they don't get used? If there are naming collisions perhaps it'd be better for us to change our names to avoid confusion with the GB mixins anyway.
Details
We're defining our own version of the
long-content-fade
mixin and it's pretty much a copy-paste of what we have in@wordpress/base-styles
.It's a good idea to remove our version and use the one shipped by the agnostic package. That way, we'd have a single source of truth and something that the community maintains, essentially one less point of maintenance for us.
Checklist
@wordpress/base-styles
, extract thelong-content-fade
mixin to its own file so we can import it exclusivelylong-content-fade
file insideclient/assets/stylesheets/shared/mixins/_mixins.scss
long-content-fade
did not introduce regressions, including the places where we're not defining the$color
variable, which has a different default value in the mixin definitionRelated
#65598.
The text was updated successfully, but these errors were encountered: