Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Styles: Extract long-content-fade to its own file so it can be imported and reused. #46485

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

vykes-mac
Copy link
Contributor

@vykes-mac vykes-mac commented Dec 12, 2022

What?

Extract the long-content-fade mixin to it's own file.

Why?

So that it can be easily reused by importing when needed. Whenever we need to use it we don't have to include the other mixins in the _mixins.scss which might cause collision in other codebases.

How?

I'm moving the long-content-fade mixin from the _mixins.scss file into it's own file so it can be imported and reused easily.

Testing Instructions

  1. Checkout his branch to your local repo
  2. Verify _long-content-fade.scss can be imported without build errors.
  3. In editor add a search block and remove buttons and labels. Preview the post:
    - in html remove search block .wp-block-search__inside-wrapper
    - add class
.search-component__input-fade {
	display: flex;
	align-items: center;
	border-radius: 0;
	flex: 1 1 auto;
	height: 100%;
	position: relative;
	&::before {
		@include long-content-fade( $direction: right, $size: 70px, $z-index: 2, $color: #fff, $edge: 1px );
		border-radius: inherit;
	}
}
  1. Verify the long-content-fade is still applied as shown below:
    image
    Notice fading edges where the text overflows.

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @vykes-mac! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@vykes-mac vykes-mac marked this pull request as draft December 19, 2022 15:05
@vykes-mac vykes-mac marked this pull request as ready for review December 19, 2022 19:01
@danielbachhuber danielbachhuber added the [Package] Base styles /packages/base-styles label Dec 21, 2022
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @vykes-mac ! Thanks for the detailed description 😊

@danielbachhuber danielbachhuber merged commit efab914 into WordPress:trunk Dec 21, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @vykes-mac! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 14.9 milestone Dec 21, 2022
@jeffpaul
Copy link
Member

@vykes-mac checking back in to see if you're able to confirm your username on WordPress.org so that we can properly credit you within the WordPress 6.2 release later this month?

@vykes-mac
Copy link
Contributor Author

Hi @jeffpaul my username on wordress.org is vykesmac.

@jeffpaul
Copy link
Member

@vykes-mac wonderful, thank you! If you follow the steps in #46485 (comment), then next time this will happen automatically and I won't have to chase down this thread to remember/find your WordPress.org account... thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Base styles /packages/base-styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants