-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front Page template with static homepage breaks the template editor #81928
Comments
📌 REPRODUCTION RESULTS
📌 FINDINGS/SCREENSHOTS/VIDEO 📌 ACTIONS
📌 Message to Author |
FYI, I can reproduce this issue with the exact same steps as @tanjoymor mentioned in the issue description. (I used Exmoor theme.) |
Thanks @fushar ! Glad to see Lego is looking into this as well. 📌 REPRODUCTION RESULTS
📌 FINDINGS/SCREENSHOTS/VIDEO Simple V4eQWi.movAtomic da1C3N.mp4Self-Hosted with 📌 ACTIONS
|
I encountered this while troubleshooting a user report in 7094522-zen |
Support References This comment is automatically generated. Please do not edit it.
|
An additional issue has been discovered on this with regards to the Posts Page setting too.
I'll try to grab a recording of this situation when I have more time. |
I tested again using the latest Gutenberg v16.7.0 (by adding However, clicking "Edit Template" opens up the Pages template now, not the Front Page template. (Not sure if this is expected?) Can anyone else also test on Gutenberg v16.7.* ? |
Tested it via the JN site with the Gutenberg v16.7.0, and it seems to work as expected when I tried to edit the Front Page template. But it's weird that I cannot see the |
In my testing, I was able to do that by clicking on the Content block; then a notification will appear at the bottom-left corner: But, as I mentioned above, it will somehow open up the What's your experience @arthur791004 , could you describe? |
Sometimes I can see the notification but sometimes I cannot 😞
Yes, I also saw the Pages template on the block settings of the Sidebar in the Site Editor. However, it showed the Front Page template in the Page Editor... Here is my demo. I spent some time to find how to trigger the notification to edit the Pages template but it never showed 😅 Screen.Recording.2023-10-02.at.5.51.09.PM.mov |
I've created a recording, using a Pressable (self-hosted) site to demonstrate all the oddities happening with themes that use the Front Page template. The behavior of these themes has changed from the way they used to work, I'm not sure what the change/cause might be or when exactly it happened. The only anchor in timing that I have is that it was working as expected on August 4th. So it seems to have been a change that took place some time between August 4th and September 19th, which could possibly be further narrowed down by trimming another week off of those two dates, because it was working for a while after August 4th and I noticed the issue a bit prior to creating this GH issue. So maybe something between August 10th and September 7th - ish. At least as a start point for investigating. This recording first goes through the settings and situations without the GB plugin (up to the 8:15 timestamp) and then goes through the steps with GB 16.7 active through to the end of the recording. And I explain my way through the recording. Front.Page.template.issues.mp4 |
@tanjoymor This should have been fixed in the latest GB version. Could you check? @Automattic/lego will also check. |
@autumnfjeld I guess that depends on how we're defining "fixed". At the moment, themes with the Front Page template are now behaving completely different to how they have always behaved, but the blocks do seem to be working in terms of being able to edit things again. So if the goal was to make the Front Page template no longer be the aggressive template it used to be, and to have it no longer override the Homepage settings, yes that appears to be the case, which is going to require a mental shift and updates to several materials to explain that it works differently now. After some quick testing, it seems that the Front Page template is now behaving the same way as either the Blog Home or Index template. Which I'll be honest, based on past conversations, I didn't even think was possible. This also means that now, there is no way to assign a featured image or custom excerpt to the Homepage of a site that is using the default template for the Homepage on a Dotcom Simple site, and the only way to do it on an Atomic or self-hosted site is with a plugin. (This undoes the discoveries that @fushar and I had made regarding this point and the ability to use the Front Page template connected to a regular page as a work around.) |
Are you sure? I just tested with the following steps and the template hierarchy seems to be respected:
|
But one thing is still broken here. When I open the Site Editor, it will open the static page (wrong) instead of the This does not happen in Core (I tested a Jurassic Ninja site). |
@tanjoymor I opened a new issue instead: #82910 Could you confirm that we can close this issue as the original issue that you reported is resolved? 🙏 |
This ^ I just came back here to say I've done more testing and found the same situation as you. So yes, the original issue of this GH seems fixed and can be closed. I guess we'll see if that's still the case when the new issue is fixed. |
Quick summary
When a theme comes with the Front Page template (StartFit, Exmoor) and you assign a static homepage, the Site Editor template breaks in that you can't select or edit the blocks added in the template.
This is a problem because assigning a static homepage is the only way for a Simple site to be able to assign a Featured Image or control a custom excerpt for the Homepage for SEO and social sharing purposes.
mJjjqy.mp4
Steps to reproduce
What you expected to happen
I expected the template editor to work as normal when a static (custom) homepage is assigned.
What actually happened
Most blocks within the Front Page template in the Site Editor are missing from the List View and you can't select any of the content or edit it.
Impact
All
Available workarounds?
No and the platform is unusable
Platform (Simple and/or Atomic)
Simple, Atomic
Logs or notes
My screen recording is with an Atomic Staging Site, I've confirmed the behavior in a regular Atomic site and a Simple site. I haven't tested in a self-hosted site.
The text was updated successfully, but these errors were encountered: