Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor shows the static page from "Your homepage displays" setting even though Front Page template is used #82910

Closed
fushar opened this issue Oct 12, 2023 · 8 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@fushar
Copy link
Contributor

fushar commented Oct 12, 2023

Quick summary

When a Front Page template is used (active) in the site, it will be always used as the site homepage. So, opening the Site Editor by default should always show this template.

However, when we set the Settings -> Reading -> "Your homepage displays" to a static page, opening the Site Editor will open that static page, which is unexpected. Even worse, clicking the "Edit template" link (which appears when we click on any editable area of the editor) will open the Pages template, not Front Page template.

So, the only way to edit the homepage (i.e. the Front Page template) is to open the template manually in the Templates menu.

This is a regression; this used to be correct before. This does not happen in Core. @tanjoymor has a guesstimate of the timing when it possibly started breaking, in a previous discussion where a related issue happened (#81928)

The only anchor in timing that I have is that it was working as expected on August 4th. So it seems to have been a change that took place some time between August 4th and September 19th, which could possibly be further narrowed down by trimming another week off of those two dates, because it was working for a while after August 4th and I noticed the issue a bit prior to creating this GH issue. So maybe something between August 10th and September 7th - ish. At least as a start point for investigating.

cc: @Automattic/lego

Steps to reproduce

  1. Activate a theme which has Front Page template active (e.g. Kigen)
  2. Now go to Settings -> Reading; set the "Your homepage displays" option to anything other than --Default-- (for example, the About page). Click "Save settings".
  3. Go to Appearance -> Editor.

What you expected to happen

The Front Page template should be shown.

What actually happened

The About page is shown instead.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

@fushar fushar added [Type] Bug Needs triage Ticket needs to be triaged [Feature] Full Site Editor The site editor. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. labels Oct 12, 2023
@tanjoymor
Copy link

Yes, I can confirm this behavior with the Enroute theme as well, for both Simple and Atomic sites.

@cuemarie
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

This is reproducible in a self-hosted environment, not just in WordPress.com. Tested with theme Kigen. I think this boils down to confusing relationship(s) between block themes, Reading Settings, and then specific themes that have a Front Page template. I don't see a specific issue about this in /gutenberg at the moment, but there are many that reference these relationships needing improvement.

Self-Hosted - Gutenberg 16.8.1 & 16.7.1 exhibit this behavior

749Q7X.mov

📌 ACTIONS

@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Oct 17, 2023
@fushar
Copy link
Contributor Author

fushar commented Nov 23, 2023

@jp-imagines
Copy link

Ran into an instance of this in 7363302-zd-a8c.

Seems it's been fixed in WordPress/gutenberg#56418, just waiting on that to be released with Gutenberg 17.2 it looks like.

Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 7363302-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Nov 29, 2023
@ellatrix
Copy link
Contributor

The core issue (#56267) has been marked as fixed, but I'm not sure if it's fixed here. I'm also a bit confused about what you're expecting. You select a page as your front page, but then don't expect that to be the front page in the Site Editor?

@tanjoymor
Copy link

tanjoymor commented Aug 27, 2024

@ellatrix

I'm also a bit confused about what you're expecting. You select a page as your front page, but then don't expect that to be the front page in the Site Editor?

Not when the front_page.html template is active. This template should “be” the Homepage regardless of any assigned regular page. So when you go to the Site Editor, you should be seeing the Front Page template content, not the assigned page content.

The reason to assign a page is to gain access to things like setting the featured image on the Homepage when it is “content in template”.

@annezazu
Copy link

annezazu commented Sep 5, 2024

Got it! In this case though, the original issue was resolved: WordPress/gutenberg#56418 I just tested and can confirm it works correctly now.

@annezazu annezazu closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] Low [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

6 participants