Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert/eslint 4 #18108

Merged
merged 2 commits into from
Sep 17, 2017
Merged

Revert/eslint 4 #18108

merged 2 commits into from
Sep 17, 2017

Conversation

oandregal
Copy link
Contributor

@oandregal oandregal commented Sep 17, 2017 •
edited
Loading

We found some issues on upgrading to ESLint v4. Will need more time to investigate, so in the meantime, I'm reverting the upgrade.

Testing

  • Checkout this branch.
  • Add an arrow function as a property of a class. For example, in client/account-recovery/components/account-recovery-error-message/index.jsx
  • Expected result is that you'll be able to commit your changes and no-undef errors are reported. Before this change, the commit hook won't let you add them and would report a no-undef issue.

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=revert/eslint-4

@oandregal oandregal mentioned this pull request Sep 17, 2017
Closed
tyxla
tyxla approved these changes Sep 17, 2017
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests as expected 👍

@oandregal oandregal merged commit 511faff into master Sep 17, 2017
@oandregal oandregal deleted the revert/eslint-4 branch September 17, 2017 19:14
@klimeryk klimeryk mentioned this pull request Oct 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @matticbot @tyxla