-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: adding Ebanx fields and validation to tef #24240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Status] In Progress
[Feature] Checkout
The checkout screen and process for purchases made on WordPress.com.
labels
Apr 17, 2018
ramonjd
force-pushed
the
add/ebanx-fields-and-validation-tef
branch
from
April 19, 2018 06:40
3d44ac3
to
18b940f
Compare
ramonjd
force-pushed
the
add/ebanx-fields-and-validation-tef
branch
from
April 19, 2018 06:53
18b940f
to
1095d78
Compare
es lint errors in CI will be addressed by #24308 |
ramonjd
force-pushed
the
add/ebanx-fields-and-validation-tef
branch
from
April 20, 2018 02:34
bf9d339
to
9e41cfc
Compare
ramonjd
force-pushed
the
add/ebanx-fields-and-validation-tef
branch
from
April 20, 2018 02:37
9e41cfc
to
631a20d
Compare
ramonjd
changed the title
[WIP] Checkout: adding Ebanx fields and validation to tef
Checkout: adding Ebanx fields and validation to tef
Apr 20, 2018
yoavf
force-pushed
the
add/ebanx-tef
branch
3 times, most recently
from
April 22, 2018 10:00
0693110
to
1d8a0bd
Compare
yoavf
force-pushed
the
add/ebanx-fields-and-validation-tef
branch
from
April 22, 2018 10:03
683f81d
to
5c32e09
Compare
4 tasks
yoavf
approved these changes
Apr 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the exception of the code from #24294, this LGTM and works as expected. Thanks!
ramonjd
force-pushed
the
add/ebanx-fields-and-validation-tef
branch
from
April 23, 2018 04:06
5c32e09
to
5763363
Compare
…'BR' ]` Adding validation - still WIP Toying with further ebanx abstraction ( remove this commit after updating ebanx fields )
Added snapshot test for select box
ramonjd
force-pushed
the
add/ebanx-fields-and-validation-tef
branch
from
April 23, 2018 04:23
5763363
to
f83aa1d
Compare
yoavf
pushed a commit
that referenced
this pull request
Apr 25, 2018
* initial commit * initial commit to be squashed, and revert `paymentMethods.byCountry[ 'BR' ]` Adding validation - still WIP Toying with further ebanx abstraction ( remove this commit after updating ebanx fields ) * Updated tests for TEF/Ebanx * Updated tests for redirect payment box Added snapshot test for select box
yoavf
pushed a commit
that referenced
this pull request
May 14, 2018
* initial commit * initial commit to be squashed, and revert `paymentMethods.byCountry[ 'BR' ]` Adding validation - still WIP Toying with further ebanx abstraction ( remove this commit after updating ebanx fields ) * Updated tests for TEF/Ebanx * Updated tests for redirect payment box Added snapshot test for select box
ramonjd
added a commit
that referenced
this pull request
May 15, 2018
* initial commit * initial commit to be squashed, and revert `paymentMethods.byCountry[ 'BR' ]` Adding validation - still WIP Toying with further ebanx abstraction ( remove this commit after updating ebanx fields ) * Updated tests for TEF/Ebanx * Updated tests for redirect payment box Added snapshot test for select box
ramonjd
pushed a commit
that referenced
this pull request
May 15, 2018
wip: add tef Checkout: adding Ebanx fields and validation to tef (#24240) * initial commit * initial commit to be squashed, and revert `paymentMethods.byCountry[ 'BR' ]` Adding validation - still WIP Toying with further ebanx abstraction ( remove this commit after updating ebanx fields ) * Updated tests for TEF/Ebanx * Updated tests for redirect payment box Added snapshot test for select box Checkout: add masking to redirect ebanx fields (#24517) * Initial commit Relocated masking rules to use in all checkout-related forms Added and updated test suites * Masking values for redirect payment form rename tef to brazil-tef for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using #23830 as a base, we're adding Ebanx fields to the TEF (bank transfer) payment panel.
Most of the work entailed plugging in some sort of consistent validation, and depends on #24294 being deployed.
For a background see: pxLjZ-4BN-p2
Notes
Validation for the fields, though extensible, is very basic. Aside from checking the tax number, there is no type, length or other validity checks on the data happening on the frontend.
For now, I've build inline validation only for
tef
to at least keep this page consistent.Testing
D11441-code
, change your currency to BRL, and hardcode 'BR' as the property ofbyCountry
Expectations
At 3:
You should see the name, bank and all the Ebanx field values
At 4:
Inline clientside validation errors should show
At 5:
The following data object will be sent (among other data) in the POST data: