Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Notices: fix plurals on RECEIVE_PLUGINS error notice #24329

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Apr 19, 2018

Correct plural arguments to i18n.translate.

Also changes this.props.translate to i18n.translate. Referencing this.props accidentally worked, too, because the module is a React mixin that gets mixed into a localized React component, but it's a small miracle that it did 😉

@jsnajdr jsnajdr added [Type] Bug [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. labels Apr 19, 2018
@jsnajdr jsnajdr self-assigned this Apr 19, 2018
@matticbot
Copy link
Contributor

@jsnajdr jsnajdr requested a review from akirk April 19, 2018 14:25
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@akirk akirk added the i18n label Apr 19, 2018
@jsnajdr jsnajdr merged commit 8ec2cba into master Apr 19, 2018
@jsnajdr jsnajdr deleted the fix/plugins-notice-translation branch April 19, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. i18n [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants