Checkout: Normalizing top padding of the credit card form #24487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding applies and first field (name) does not contain top padding.
ramonjd
added
[Type] Bug
[Feature] Checkout
dechov
approved these changes
Apr 26, 2018
| @@ -38,7 +38,9 @@ | |||
| .credit-card-form-fields__field { | |||
| margin-top: 15px; | |||
| position: relative; | |||
|
|
|||
There was a problem hiding this comment.
Consider keeping line breaks around these blocks?
alisterscott
added
the
[Status] Needs Review
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a UI regression that #24294 introduced.
Props to @dechov
Testing
/me/purchases/add-credit-cardExpectations
At 1:
There should be no extra padding in selected saved cards
At 2 and 3:
There should be no extra padding above the first field (name field)