Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update babel monorepo to v7.0.0 #26497

Merged
merged 4 commits into from
Aug 29, 2018
Merged

Update babel monorepo to v7.0.0 #26497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aaa5ef0
Update babel monorepo to v7.0.0-rc.1
renovate-bot Aug 10, 2018
ed7daaf
update babel config for rc0
blowery Aug 10, 2018
7c033db
Upgrade to Babel 7.0.0
jsnajdr Aug 28, 2018
5feb43f
Media Actions test: add Symbol.iterator prop to mock FileList prototype
jsnajdr Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ const config = {
[
'@babel/transform-runtime',
{
corejs: false, // we polyfill so we don't need core-js
helpers: true,
polyfill: false,
regenerator: false,
useESModules: false,
Copy link
Member

@gziolo gziolo Aug 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use Babel helpers with import/export syntax by enabling useESModules?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useESModules: true indeed looks interesting: the Babel helpers (i.e., node_modules/@babel/runtime/helpers/esm/inherits.js) are then imported in a ES6 module rather than CommonJS version. There is negligible impact on build size though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, given that polyfills are off, it probably doesn't matter.

},
],
isCalypsoClient && './inline-imports.js',
Expand Down
1 change: 1 addition & 0 deletions client/lib/media/test/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ describe( 'MediaActions', () => {
sandbox.stub( stubs, 'mediaDelete' ).callsArgWithAsync( 0, null, DUMMY_API_RESPONSE );
MediaActions._fetching = {};
window.FileList = function() {};
window.FileList.prototype[ Symbol.iterator ] = Array.prototype[ Symbol.iterator ];
window.URL = { createObjectURL: sandbox.stub() };
mockReduxPostId = null;
} );
Expand Down
Loading