Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: dispatchRequest update (sites users select) #27615

Merged
merged 11 commits into from
Oct 10, 2018
Merged

Framework: dispatchRequest update (sites users select) #27615

merged 11 commits into from
Oct 10, 2018

Commits on Oct 3, 2018

  1. Swap dispatchRequest() for dispatchRequestEx() in the users selec… 

    …tor.
    @sixhours
    sixhours committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    6d734e9 View commit details
    Browse the repository at this point in the history

  2. Begin updating tests to remove spies.

    @sixhours
    sixhours committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    065860f View commit details
    Browse the repository at this point in the history

  3. Update tests

    @sixhours
    sixhours committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    f9c9d39 View commit details
    Browse the repository at this point in the history

  4. Remove inaccurate code comments

    @sixhours
    sixhours committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    7389caa View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2018

  1. Update tests

    @sixhours
    sixhours committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    7e15ad8 View commit details
    Browse the repository at this point in the history

  2. Oops, the receiveSuccess function was not returning anything.

    @sixhours
    sixhours committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    4fde4ea View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. Users State: add USERS_RECEIVE action to receive a list of users

    @jsnajdr
    jsnajdr committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    ff0c177 View commit details
    Browse the repository at this point in the history

  2. Users State: migrate reducer test to Jest expectations

    @jsnajdr
    jsnajdr committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    963170c View commit details
    Browse the repository at this point in the history

  3. Users State: use USERS_RECEIVE to store page of user results, fix iss… 

    …uing request for next page

Improve the `receiveSuccess` handler to first store the just-received page of user results using
the `USERS_RECEIVE` action, and then optionally issue a request for the next page.
    @jsnajdr
    jsnajdr committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    ff374b7 View commit details
    Browse the repository at this point in the history

  4. Users State: update JSDoc comments and make the data-layer handler fi… 

    …le ESLint-clean
    @jsnajdr
    jsnajdr committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    9b47c86 View commit details
    Browse the repository at this point in the history

  5. Users State: update the data layer tests for USERS_REQUEST

    @jsnajdr
    jsnajdr committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    f057e1f View commit details
    Browse the repository at this point in the history