Gutenberg: use v1.2 endpoint to create auto-draft #27673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
[Status] Needs Review
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
Copons
reviewed
Oct 9, 2018
client/state/data-getters/index.js
Outdated
| export const requestSitePost = ( siteId, postId, postType ) => { | ||
| //post and page types are plural except for custom post types | ||
| //eg /sites/<siteId>/posts/1234 vs /sites/<siteId>/jetpack-testimonial/4 | ||
| const s = postType === 'page' || postType === 'post' ? 's' : ''; |
There was a problem hiding this comment.
This is a clever one, but I'm personally not a big fan of adding the plural s this way, and I'd rather have a more straightforward if/else-if/else, with the additional advantage of being self-explanatory.
gwwar
force-pushed
the
update/auto-draft
branch
from
daca31f
to
f2383b3
Compare
|
I made the path logic less clever in f2383b3! Thanks for the review @Copons ✨ |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27430 by updating our API call to use our v1.1 endpoint to create an auto-draft The Core
wp/v2endpoint does not allow creation ofauto-drafts. Our previous custom endpoint did not allow us to fetch all post types from Jetpack sites.Note that autosaves for custom post types don't appear to work
cc @mdawaffe I've added #27674
Testing Instructions
http://calypso.localhost:3000/gutenberg/post/<site>http://calypso.localhost:3000/gutenberg/page/<site>http://calypso.localhost:3000/gutenberg/edit/<cpt>/<site>