Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused "build-desktop" package.json commands #27684

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Remove the unused "build-desktop" package.json commands #27684

merged 1 commit into from
Oct 10, 2018

Conversation

DanReyLop
Copy link
Contributor

@DanReyLop DanReyLop commented Oct 9, 2018 •
edited
Loading

I've checked in the wp-desktop repo and they're not using the npm run pre/post/build-desktop commands anymore. So, it's just dead code.

Testing instructions

Not needed. I'm just removing dead code.

@DanReyLop DanReyLop added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Build labels Oct 9, 2018
@DanReyLop DanReyLop self-assigned this Oct 9, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/dead-package-json-commands

@DanReyLop DanReyLop requested a review from sirreal October 9, 2018 15:40
@ghost
Copy link

ghost commented Oct 9, 2018

Warnings
⚠️

"Testing instructions" are missing for this PR. Please add some.

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Calypso maintainers do their job. If you think 'Testing instructions' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

sirreal
sirreal approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've searched in this repo and the desktop repo and this does appear to be unused 👍

Thanks for the cleanup!

@DanReyLop DanReyLop merged commit a0f5fcf into master Oct 10, 2018
@DanReyLop DanReyLop deleted the remove/dead-package-json-commands branch October 10, 2018 09:42
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

Assignees

@DanReyLop DanReyLop

Labels
Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanReyLop @matticbot @sirreal