Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: Pass "engine" and "from_site" to new user endpoint #27831

Merged
merged 2 commits into from
Oct 16, 2018

Conversation

jonathansadowski
Copy link
Contributor

@jonathansadowski jonathansadowski commented Oct 12, 2018

Changes proposed in this Pull Request

This PR passes the "engine" and "from_site" to the new user endpoint, which allows us to continue the import flow after email confirmation.

Testing instructions

  • Apply changes from D19275-code and D19384-code and follow the associated test plans (make sure appropriate sites are sandboxed).
  • Open the network inspector to capture the request to the new user endpoint (filter for "new")
  • Browse to http://calypso.localhost:3000/start/import
  • Enter a known valid wix site to import
  • Submit the form
  • Complete the signup
  • Verify that import_engine and import_site are correctly populated and sent to the new user endpoint via the network inspector

Addition testing that should pass if both D19275-code and D19384-code are applied:

  • Click the confirmation link you receive via email
  • Verify that you're redirected to the import flow and shown a preview of your site.

@matticbot
Copy link
Contributor

@ghost
Copy link

ghost commented Oct 12, 2018

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@jonathansadowski jonathansadowski requested a review from a team October 16, 2018 20:40
@jonathansadowski jonathansadowski added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Oct 16, 2018
@jblz
Copy link
Member

jblz commented Oct 16, 2018

I hit a reference error when I went through a logged out flow with this on the last screen, but it "worked" (created the user w/ attrs, site, etc).

screen shot 2018-10-16 at 5 12 22 pm

Looking to see if it's in master as well.

Copy link
Member

@jblz jblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that bug is in master, so this is a 👍 from me and I'll chase that bug in another PR.

@jonathansadowski
Copy link
Contributor Author

Thanks for the review, and thanks for chasing that bug down.

@jonathansadowski jonathansadowski merged commit 59ff2ef into master Oct 16, 2018
@jonathansadowski jonathansadowski deleted the update/import-account-creation branch October 16, 2018 21:26
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2018
@jblz
Copy link
Member

jblz commented Oct 16, 2018

I'm pretty sure my error was because of something broken on my sandbox. Can no longer reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants