-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import: Pass "engine" and "from_site" to new user endpoint #27831
Conversation
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
443ae14
to
ccc1430
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that bug is in master, so this is a 👍 from me and I'll chase that bug in another PR.
Thanks for the review, and thanks for chasing that bug down. |
I'm pretty sure my error was because of something broken on my sandbox. Can no longer reproduce. |
Changes proposed in this Pull Request
This PR passes the "engine" and "from_site" to the new user endpoint, which allows us to continue the import flow after email confirmation.
Testing instructions
import_engine
andimport_site
are correctly populated and sent to the new user endpoint via the network inspectorAddition testing that should pass if both D19275-code and D19384-code are applied: