Fix label printing in iOS 12 #27897
Merged
Fix label printing in iOS 12 #27897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanReyLop
added
[Status] Needs Review
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
marcinbot
approved these changes
Oct 17, 2018
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS 12, something changed that broke our shipping label printing. After clicking the "Print" button, a new tab opens but instead of seeing the label PDF you see this error:
Changes proposed in this Pull Request
This PR adds a time-out before invalidating the shipping label's PDF
blob:URL so it works in iOS 12.Testing instructions
iOS 12device or simulator.master, you'd get an error when clicking the "Print" button (see screenshot).Fixes this user-reported bug