-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove node's url from lib/i18n-utils. #38560
Conversation
Also adds a new `getUrlFromParts` to `lib/url`.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~1661 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~124829 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 Tests well for me. Also, thanks for the globalThis
/window
tidying.
Thanks for the review, @griffbrad ! |
Also adds a new
getUrlFromParts
method tolib/url
.Changes proposed in this Pull Request
getUrlFromParts
method tolib/url
.node
's deprecatedurl
module fromlib/i18n-utils
.Testing instructions
Ensure that the unit tests for
lib/i18n-utils
continue to work correctly.