-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to core-js@3. #38660
Merged
Merged
Upgrade to core-js@3. #38660
Commits on Jan 13, 2020
-
This entails not only updating the package, but also: - Setting the core-js version in the babel config. - Dropping @babel/polyfill and using core-js directly. - Removing superfluous polyfills (e.g. URL). - Removing superfluous runtime module replacements in evergreen. - Modifying several entry points to use boot/polyfills rather than their own code, including the server entry point. - Minor lint fixes. Remove polyfill-specific lib/url tests. Don't use boot in standalone notifications. Don't depend on boot from packages. Update core-js to 3.6.2 to fix regex bugs. Switch corejs option in preset-env to `3`. Update core-js to 3.6.3.
Configuration menu - View commit details
-
Copy full SHA for c8a96a0 - Browse repository at this point
Copy the full SHA c8a96a0View commit details -
Explicitly include
globalThis
polyfill.For some reason, it's not included in `stable` as it should be. Also ensure that gridicons are transpiled.
Configuration menu - View commit details
-
Copy full SHA for bd91261 - Browse repository at this point
Copy the full SHA bd91261View commit details
Commits on Jan 14, 2020
-
Switch back to core-js: 3.6 in config.
This helps avoid the globalThis workaround.
Configuration menu - View commit details
-
Copy full SHA for b274846 - Browse repository at this point
Copy the full SHA b274846View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24f3769 - Browse repository at this point
Copy the full SHA 24f3769View commit details -
Configuration menu - View commit details
-
Copy full SHA for da74522 - Browse repository at this point
Copy the full SHA da74522View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a01300 - Browse repository at this point
Copy the full SHA 5a01300View commit details
Commits on Jan 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7d1f84f - Browse repository at this point
Copy the full SHA 7d1f84fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee9bcf - Browse repository at this point
Copy the full SHA 7ee9bcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bdc4eb - Browse repository at this point
Copy the full SHA 6bdc4ebView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.