Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update wordpress monorepo (take 2) #41994

Closed
wants to merge 4 commits into from
Closed

fix(deps): update wordpress monorepo (take 2) #41994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15bff06
Fixes for upgrade
sirreal May 14, 2020
aad6212
Upgrade @wordpress/* dependencies
sirreal May 8, 2020
dc29eae
Yarn deduplicate
sirreal May 14, 2020
8a02e79
yarn (undeduplicate?)
sirreal May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/full-site-editing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@
"@wordpress/element": "*",
"@wordpress/hooks": "*",
"@wordpress/html-entities": "*",
"@wordpress/icons": "*",
"@wordpress/i18n": "*",
"@wordpress/icons": "*",
"@wordpress/keycodes": "*",
"@wordpress/plugins": "*",
"@wordpress/rich-text": "*",
Expand Down
10 changes: 7 additions & 3 deletions client/components/select-dropdown/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ describe( 'index', () => {
const escapeKeyCode = 27;
const escEvent = createKeyEvent( escapeKeyCode );

const dropdown = mountDropdown();
const dropdown = mountDropdown( true );
dropdown.setState( { isOpen: true } );

const container = dropdown.find( '.select-dropdown__container' );
Expand All @@ -206,6 +206,7 @@ describe( 'index', () => {
sinon.assert.calledOnce( escEvent.preventDefault );
// check that container was focused
expect( container.instance() ).to.equal( document.activeElement );
dropdown.unmount();
} );

describe( "permits to open the dropdown, and navigate through the dropdown's options by ", () => {
Expand All @@ -232,9 +233,12 @@ describe( 'index', () => {
* Utilities
*/

function mountDropdown() {
function mountDropdown( attach = false ) {
const dropdownOptions = getDropdownOptions();
return mount( <SelectDropdown options={ dropdownOptions } /> );
return mount(
<SelectDropdown options={ dropdownOptions } />,
attach ? { attachTo: document.body } : undefined
);
}

function shallowRenderDropdown( props ) {
Expand Down
Loading