Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: Re-register core patterns to push them down in the editor's inserter list #83571

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

miksansegundo
Copy link
Contributor

Related to #77130

Proposed Changes

  • Re-register the core pattern core/social-links-shared-background-color to push it down in the list.
  • The function is ready for adding more pattern names easily

This PR allows curating the order of core patterns in the editor's inserter so Dotcom can move some patterns down in the list based on their look.

BEFORE AFTER
Screenshot 2566-10-27 at 11 53 17
Screen.Recording.2566-10-27.at.11.52.21.mov

Testing Instructions

  • Sandbox the public-api and your site
  • Run in your sandbox install-plugin.sh editing-toolkit fix/push-a-core-pattern-down-in-the-list
  • Access the editor { SITE }/wp-admin/site-editor.php or the post/page editor
  • Verify the pattern "Social links shared background color" is not at the top of the list in the category "Call to action"
  • Revert your sandbox install-plugin.sh editing-toolkit --revert

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@miksansegundo miksansegundo requested a review from a team October 27, 2023 05:07
@miksansegundo miksansegundo self-assigned this Oct 27, 2023
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 27, 2023
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matticbot
Copy link
Contributor

matticbot commented Oct 27, 2023

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/push-a-core-pattern-down-in-the-list on your sandbox.

@miksansegundo miksansegundo merged commit 4f3e4b5 into trunk Oct 27, 2023
12 checks passed
@miksansegundo miksansegundo deleted the fix/push-a-core-pattern-down-in-the-list branch October 27, 2023 10:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants