Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Preview: remove the welcome modal #86385

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Jan 15, 2024

Related to:

Proposed Changes

This removes the old Live Preview Modal as it is replaced by Automattic/jetpack#34935.

This should ONLY be deployed shortly before we release the above PR.

Note: we tried hiding this modal when showing the new modal but it does not always work, so we removed the code via Automattic/jetpack@85c2cc2.

Testing Instructions

  1. Sandbox your site.
  2. Patch this: install-plugin.sh etk live-preview-modal-remove
  3. Live-preview a theme; verify that no modal is shown.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@fushar fushar requested a review from a team January 15, 2024 06:45
@fushar fushar self-assigned this Jan 15, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 15, 2024
Copy link

github-actions bot commented Jan 15, 2024

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • editing-toolkit
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug live-preview-modal-remove on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@miksansegundo miksansegundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The welcome modal is not shown:

Screen.Recording.2567-01-15.at.13.54.17.mov

Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@fushar fushar merged commit 6439757 into trunk Jan 17, 2024
16 of 21 checks passed
@fushar fushar deleted the live-preview-modal-remove branch January 17, 2024 12:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants