-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Preview: remove the welcome modal #86385
Conversation
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The welcome modal is not shown:
Screen.Recording.2567-01-15.at.13.54.17.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Related to:
Proposed Changes
This removes the old Live Preview Modal as it is replaced by Automattic/jetpack#34935.
This should ONLY be deployed shortly before we release the above PR.
Note: we tried hiding this modal when showing the new modal but it does not always work, so we removed the code via Automattic/jetpack@85c2cc2.
Testing Instructions
install-plugin.sh etk live-preview-modal-remove
Pre-merge Checklist