Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove styles for non-existent DOM #96226

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Nov 11, 2024

Related to #

Proposed Changes

Remove styles for non-existent DOM in Dotcom's Sites Dashboard (they were for A4A).

Why are these changes being made?

pbxlJb-6DF-p2

Testing Instructions

  • Go to /sites
  • Observe nothing breaks

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@okmttdhr okmttdhr self-assigned this Nov 11, 2024
@okmttdhr okmttdhr marked this pull request as ready for review November 11, 2024 08:00
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/refine-dotcom-dataview-remove-non-exists on your sandbox.

@okmttdhr okmttdhr requested review from cleacos and a team November 11, 2024 08:07
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 11, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@okmttdhr okmttdhr merged commit 062f293 into trunk Nov 12, 2024
15 checks passed
@okmttdhr okmttdhr deleted the fix/refine-dotcom-dataview-remove-non-exists branch November 12, 2024 01:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants