Autoload files on demand to avoid loading the whole library #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modeled after: xlab-si/intersight-sdk-ruby#14 Note, this saves around 6 MB of memory by delay loading 214 files. Future plugins could use useAutoload option to autoload. This was added in 6.1.0 of the openapi-generator: OpenAPITools/openapi-generator#13153 Note, this library has non-standard class names, even within the same plugin, such as SDE capitalized in AutoSDEProject but not in AutosdeOpenapiClient. To workaround this, I had to validate that all classes we try to autoload can actually be loaded. I've added a variation of the script from xlab-si/intersight-sdk-ruby#14 which checks all classes can be loaded.
|
cc @agrare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeled after: xlab-si/intersight-sdk-ruby#14
Note, this saves around 6 MB of memory by delay loading 214 files.
Future plugins could use useAutoload option to autoload. This was added in 6.1.0 of the openapi-generator:
OpenAPITools/openapi-generator#13153
Note, this library has non-standard class names, even within the same plugin, such as SDE capitalized in AutoSDEProject but not in AutosdeOpenapiClient. To workaround this, I had to validate that all classes we try to autoload can actually be loaded. I've added a variation of the script from xlab-si/intersight-sdk-ruby#14 which checks all classes can be loaded.