make docker build optinal from release workflow #399
Conversation
.github/workflows/release.yml
Outdated
| secrets: | ||
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
| if: github.event.inputs.draft == 'true' |
There was a problem hiding this comment.
@chrisli30 I extract into a standalone job so we can run it separately, but at the same time I run this optinally so we don't need to remember to run 2 jobs.
There was a problem hiding this comment.
Hmm I think we can remove it from this Release script, because the Docker publish job doesn’t need to run until the very end of the release, and as you said, the image is optional when upgrading Turing Network. The two jobs are not supposed to run simultaneously and have different priorities.
.github/workflows/release.yml
Outdated
| @@ -6,6 +6,10 @@ on: | |||
| tag: | |||
| description: Tag for release | |||
| required: true | |||
| draft: | |||
| description: draf release will not make the final image and skip some particular steps | |||
There was a problem hiding this comment.
darf release? 😅
skip some particular steps is vauge. Let’s avoid wordings like this and explain the most important things here.
Is it will not build and publish a Docker image on Dockerhub?
.github/workflows/release.yml
Outdated
| secrets: | ||
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
| if: github.event.inputs.draft == 'true' |
There was a problem hiding this comment.
Hmm I think we can remove it from this Release script, because the Docker publish job doesn’t need to run until the very end of the release, and as you said, the image is optional when upgrading Turing Network. The two jobs are not supposed to run simultaneously and have different priorities.
|
@chrisli30 can you review again? i just completely separate it. |
…-nmake-it-optional-when-release
v9n
deleted the
extract-docker-build-to-standalone-job-and-nmake-it-optional-when-release
branch
Address this OIP #394