Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zombienet script to fix port numbers of relay chain nodes #407

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

chrisli30
Copy link
Member

@chrisli30 chrisli30 commented Aug 6, 2023

This is a minor change to use fixed relay chain port numbers instead of randomly assigned when using zombienet. Using fixed ports will allow us to have consistent port numbers upon zombienet startup, instead of looking for a random number from the command logs.

This PR needs a rebase once #405 is approved and merged.

@chrisli30 chrisli30 requested a review from imstar15 August 6, 2023 20:48
Copy link
Member

@imstar15 imstar15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chrisli30 chrisli30 merged commit ffce251 into master Aug 7, 2023
3 checks passed
@chrisli30 chrisli30 deleted the update_zombienet_script branch August 7, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants