use Vector of old task id hash for new task id #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chrisli30 @imstar15 This is to fix the task id so after and before the task id will show up as the same task. Before update
After update and migration run
|
instead of converting the hash to its hex format and use the ascii string of the hex as Vec<u8> for new task id, we use the original [u8, 32] of the Hash and convert it to a Vec<u8> This will keep our task id show up in the same way before and after update.
v9n
force-pushed
the
fix-task-id-double-encoding-on-polkadot-ui
branch
from
962b351
to
f07c1d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of converting the hash to its hex format and use the ascii string of the hex as Vec for new task id, we use the original [u8, 32] of the Hash and convert it to a Vec
This will keep our task id show up in the same way before and after update.