Remove refund instructions #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v9n
reviewed
Sep 18, 2023
chrisli30
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Yeah @imstar15 please explain the PR when you submit it ...
@v9n, the reason of these removal is that each XCM instruction costs 1M weight, so removing the last two for refunding actually will cost users less than having a refund process.
Besides, Rocstar doesn’t allow high XCM weight per block, so reducing weight of each XCM messages will help our messages get unblocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason of these removal is that each XCM instruction costs 1M weight, so removing the last two for refunding actually will cost users less than having a refund process.
Besides, Rocstar doesn’t allow high XCM weight per block, so reducing weight of each XCM messages will help our messages get unblocked.