-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle price confirmation when running tasks #449
Merged
Merged
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 14b7cb2 - Browse repository at this point
Copy the full SHA 14b7cb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55820f9 - Browse repository at this point
Copy the full SHA 55820f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbd7242 - Browse repository at this point
Copy the full SHA fbd7242View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddf8f29 - Browse repository at this point
Copy the full SHA ddf8f29View commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 30a2391 - Browse repository at this point
Copy the full SHA 30a2391View commit details -
handle price confirmation when running tasks
The price may have changed in extreme case by the time we run the tasks, if so, we adjust accordingly and emit an event. Task won't be put back to the queue but will be removed from the queue as if it has run succesfully, but we emit the event about stale price instead of executing the task
Configuration menu - View commit details
-
Copy full SHA for 9c07a5a - Browse repository at this point
Copy the full SHA 9c07a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a81bb37 - Browse repository at this point
Copy the full SHA a81bb37View commit details -
Configuration menu - View commit details
-
Copy full SHA for d59d488 - Browse repository at this point
Copy the full SHA d59d488View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ec8f6 - Browse repository at this point
Copy the full SHA c6ec8f6View commit details -
oak-code-formatter committed
Oct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 7a98537 - Browse repository at this point
Copy the full SHA 7a98537View commit details -
Configuration menu - View commit details
-
Copy full SHA for b833073 - Browse repository at this point
Copy the full SHA b833073View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bc0788 - Browse repository at this point
Copy the full SHA 6bc0788View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.