Sweep expired tasks, fixed #442 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v9n
force-pushed
the
sweep-expired-task
branch
from
71b63f9
to
89b5bac
Compare
v9n
force-pushed
the
handle-price-move-before-task-run
branch
from
5c41a00
to
d59d488
Compare
The price may have changed in extreme case by the time we run the tasks, if so, we adjust accordingly and emit an event. Task won't be put back to the queue but will be removed from the queue as if it has run succesfully, but we emit the event about stale price instead of executing the task
v9n
force-pushed
the
sweep-expired-task
branch
from
3e4b3af
to
c0fe578
Compare
v9n
force-pushed
the
sweep-expired-task
branch
from
06e5b39
to
d4ccd48
Compare
|
Hi @chrisli30 @imstar15 This is ready to review. Please help check. Thanks. |
chrisli30
approved these changes
Oct 12, 2023
| // TaskStats: decrease task count | ||
| // AccountStats: decrease task count | ||
| // SortedTasksIndex | ||
| pub fn remove_task(task: &Task<T>, event: Option<Event<T>>) { |
There was a problem hiding this comment.
Yea definitely needs this encapsulation of remove tasks.
pallets/automation-price/src/lib.rs
Outdated
| // TaskQueue if the task is alreayd queue | ||
| // TaskStats: decrease task count | ||
| // AccountStats: decrease task count | ||
| // SortedTasksIndex |
There was a problem hiding this comment.
Let’s add comments.
SortedTasksIndex - sorted by price
Sorted TaskIds by expiration?
v9n
commented
Oct 12, 2023
| BTreeMap::<u128, TaskIdList<T>>::new() | ||
| } | ||
| #[pallet::storage] | ||
| #[pallet::getter(fn get_sorted_tasks_by_expiration)] |
There was a problem hiding this comment.
@chrisli30 This is the SortedTaskByExpiration where we store a tasks sorted by expired epoch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When block has idle time, we will run task sweep to delete expired tasks. We will run as long as we still have weight left leverage
on_idleblock https://paritytech.github.io/polkadot-sdk/master/frame_support/traits/trait.Hooks.html#method.on_idleI had a few test cases to test this extensively. When removing tasks, we also update our stat such as total task count and task count of user that has task being removed.