Fix #440 Standardize event name #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v9n
changed the base branch from
master
to
add-extra-data-to-reason-about-task-trigger
chrisli30
approved these changes
Oct 13, 2023
Base automatically changed from
add-extra-data-to-reason-about-task-trigger
to
master
October 13, 2023 01:57
this is to make our event consitent with the storage system
v9n
force-pushed
the
standarize-event-name
branch
from
45d5a1e
to
031590d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #440
At this moment, I only applied this change to automation-price first. Eventually we will need to do the same for automation-time and update insight dashboard and our GraphQL document.
In this PR scope, I just want to refactor the new code (automation price) that we know won't break anything else.