fix #447 Add rpc endpoint for AutomationPrice #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v9n
force-pushed
the
add-rpc-endpoint-for-fee
branch
2 times, most recently
from
95222ae
to
68d10e8
Compare
v9n
changed the title
v9n
force-pushed
the
fee-handle-for-automation-price
branch
from
cdc9cc0
to
369b795
Compare
v9n
force-pushed
the
add-rpc-endpoint-for-fee
branch
3 times, most recently
from
4a6001e
to
46491a6
Compare
v9n
force-pushed
the
add-rpc-endpoint-for-fee
branch
from
29bb3bb
to
1a37701
Compare
chrisli30
approved these changes
Oct 25, 2023
| @@ -24,6 +24,10 @@ include!(concat!(env!("OUT_DIR"), "/wasm_binary.rs")); | |||
|
|
|||
| use codec::{Decode, Encode, MaxEncodedLen}; | |||
| use hex_literal::hex; | |||
|
|
|||
| // TODO: The FeeDetails RPC is very similar between time/price, it maybe worth to extract them out | |||
There was a problem hiding this comment.
Yes, I recorded a Jira ticket for this TODO.
pallets/automation-price/src/lib.rs
Outdated
| #[cfg(not(feature = "dev-queue"))] | ||
| ensure_root(origin)?; | ||
| // #[cfg(not(feature = "dev-queue"))] | ||
| // ensure_root(origin)?; |
There was a problem hiding this comment.
Yeah this line is not really needed, because we always have sudo access with dev-queue in local environment.
There was a problem hiding this comment.
ah this is bad merge. we do need this. it wasn't working so i had to comment it out for test. but after I fixed in this #459 PR then the flag will be pass to this pallet.
There was a problem hiding this comment.
okay, yeah I remember commenting on this line 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I still had some compilation issue with the
runtime/oak. it looks likeruntime/oakhas missing some code around automation price pallet setup at first place.Eventually we will need to find a way to consolidate the setup between the runtime env and reduce amount of boiler plate code.