Add scheduleAs to task params (#122)

* Add scheduleAs to task params * docs(changeset): Add scheduleAs to task params * The scheduleAs parameter should be pass into schedule task function
AvaProtocol · Dec 7, 2023 · 2d5b02f · 2d5b02f
1 parent 18c3c1a
commit 2d5b02f
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 9 deletions.
diff --git a/.changeset/itchy-rats-shave.md b/.changeset/itchy-rats-shave.md
@@ -0,0 +1,5 @@
+---
+"@oak-network/sdk": patch
+---
+
+Add scheduleAs to task params
diff --git a/packages/sdk/src/index.ts b/packages/sdk/src/index.ts
@@ -34,6 +34,7 @@ interface ScheduleXcmpTaskWithPayThroughSoverignAccountFlowParams extends Schedu
 
 interface ScheduleXcmpTaskWithPayThroughRemoteDerivativeAccountFlowParams extends ScheduleXcmpTaskParams {
   destinationChainAdapter: TaskSchedulerChainAdapter;
+  scheduleAs?: HexString;
 }
 
 interface CreateTaskFuncParams {
@@ -129,8 +130,20 @@ export function Sdk() {
       params: ScheduleXcmpTaskWithPayThroughRemoteDerivativeAccountFlowParams,
       automationPriceTriggerParams: AutomationPriceTriggerParams,
     ): Promise<SendExtrinsicResult> => {
-      const { oakAdapter, destinationChainAdapter, taskPayloadExtrinsic, scheduleFeeLocation, executionFeeLocation, keyringPair, xcmOptions } =
-        params;
+      const {
+        oakAdapter,
+        destinationChainAdapter,
+        taskPayloadExtrinsic,
+        scheduleFeeLocation,
+        executionFeeLocation,
+        keyringPair,
+        xcmOptions,
+        scheduleAs,
+      } = params;
+      if (_.isEmpty(scheduleAs)) {
+        throw new Error("The scheduleAs parameter should not be empty");
+      }
+
       const createTaskFunc = (funcParams: CreateTaskFuncParams): SubmittableExtrinsic<"promise"> => {
         const { oakApi, destination, executionFee, encodedCall, encodedCallWeight, overallWeight } = funcParams;
         const taskExtrinsic = oakApi.tx.automationPrice.scheduleXcmpTaskThroughProxy(
@@ -147,7 +160,7 @@ export function Sdk() {
           encodedCall,
           encodedCallWeight,
           overallWeight,
-          u8aToHex(keyringPair.addressRaw),
+          scheduleAs,
         );
         return taskExtrinsic;
       };
@@ -214,14 +227,25 @@ export function Sdk() {
      * @returns
      */
     scheduleXcmpTimeTaskWithPayThroughRemoteDerivativeAccountFlow: async (
-      scheduleXcmpTaskParams: ScheduleXcmpTaskParams,
-      destinationChainAdapter: TaskSchedulerChainAdapter,
+      scheduleXcmpTaskParams: ScheduleXcmpTaskWithPayThroughRemoteDerivativeAccountFlowParams,
       schedule: any,
     ): Promise<SendExtrinsicResult> => {
-      const { oakAdapter, taskPayloadExtrinsic, scheduleFeeLocation, executionFeeLocation, keyringPair, xcmOptions } = scheduleXcmpTaskParams;
+      const {
+        oakAdapter,
+        destinationChainAdapter,
+        taskPayloadExtrinsic,
+        scheduleFeeLocation,
+        executionFeeLocation,
+        keyringPair,
+        xcmOptions,
+        scheduleAs,
+      } = scheduleXcmpTaskParams;
+      if (_.isEmpty(scheduleAs)) {
+        throw new Error("The scheduleAs parameter should not be empty");
+      }
+
       const createTaskFunc = (funcParams: CreateTaskFuncParams): SubmittableExtrinsic<"promise"> => {
         const { oakApi, destination, executionFee, encodedCall, encodedCallWeight, overallWeight } = funcParams;
-        console.log("scheduleFeeLocation: ", scheduleFeeLocation);
         const taskExtrinsic = oakApi.tx.automationTime.scheduleXcmpTaskThroughProxy(
           schedule,
           destination,
@@ -230,7 +254,7 @@ export function Sdk() {
           encodedCall,
           encodedCallWeight,
           overallWeight,
-          u8aToHex(keyringPair.addressRaw),
+          scheduleAs,
         );
         return taskExtrinsic;
       };
@@ -255,7 +279,7 @@ export function Sdk() {
      * @returns
      */
     scheduleXcmpTimeTaskWithPayThroughSoverignAccountFlow: async (
-      scheduleXcmpTaskParams: ScheduleXcmpTaskWithPayThroughRemoteDerivativeAccountFlowParams,
+      scheduleXcmpTaskParams: ScheduleXcmpTaskWithPayThroughSoverignAccountFlowParams,
       schedule: any,
     ): Promise<SendExtrinsicResult> => {
       const { oakAdapter, destinationChainAdapter, taskPayloadExtrinsic, scheduleFeeLocation, executionFeeLocation, keyringPair, xcmOptions } =