Merge pull request #12322 from Gillibald/fixes/getCharacterHitFromDis…

…tance Adjust GetCharacterHitFromDistance to match what WPF expects
AvaloniaUI · Jul 25, 2023 · 40afe1b · 40afe1b
2 parents fc12649 + b6489e0
commit 40afe1b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Avalonia.Base/Media/TextFormatting/TextLineImpl.cs b/src/Avalonia.Base/Media/TextFormatting/TextLineImpl.cs
@@ -204,7 +204,7 @@ public override CharacterHit GetCharacterHitFromDistance(double distance)
 
                 if (_paragraphProperties.FlowDirection == FlowDirection.RightToLeft)
                 {
-                    currentPosition = Length - firstRun.Length;
+                    currentPosition += lineLength - firstRun.Length;
                 }
 
                 return GetRunCharacterHit(firstRun, currentPosition, 0);
@@ -216,7 +216,7 @@ public override CharacterHit GetCharacterHitFromDistance(double distance)
 
                 if (_paragraphProperties.FlowDirection == FlowDirection.LeftToRight)
                 {
-                    currentPosition = FirstTextSourceIndex + Length - lastRun.Length;
+                    currentPosition += lineLength - lastRun.Length;
                 }
 
                 return GetRunCharacterHit(lastRun, currentPosition, distance);

diff --git a/tests/Avalonia.Skia.UnitTests/Media/TextFormatting/TextLineTests.cs b/tests/Avalonia.Skia.UnitTests/Media/TextFormatting/TextLineTests.cs
@@ -713,7 +713,7 @@ public void Should_Get_CharacterHit_For_Distance_With_TextEndOfLine()
 
                 var characterHit = textLine.GetCharacterHitFromDistance(1000);
 
-                Assert.Equal(11, characterHit.FirstCharacterIndex);
+                Assert.Equal(10, characterHit.FirstCharacterIndex);
                 Assert.Equal(1, characterHit.TrailingLength);
             }
         }