Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use Tab/Enter in IME candidates list #12571

Closed
MrJul opened this issue Aug 17, 2023 · 2 comments · Fixed by #12774
Closed

Can't use Tab/Enter in IME candidates list #12571

MrJul opened this issue Aug 17, 2023 · 2 comments · Fixed by #12774

Comments

@MrJul
Copy link
Member

MrJul commented Aug 17, 2023

Describe the bug
After #12560, Tab can't be used anymore to select composition candidates, and Enter never commits the composition.

To Reproduce
Switch to Japanese Kana keyboard layout, type a few chars until the IME candidates list appear.
Try to use Tab to select a candidate: Tab is handled by Avalonia instead and the focus moves.
Try to use Enter to validate the IME: Enter is handled by Avalonia instead and inputs a line break.
(And probably other special shortcuts I'm not aware of.)

Expected behavior
While an IME session is active, the keys should go to it.

Remarks
I'm not sure what's the best resolution is here, the reversed TextInput/KeyDown events order before #12560 wasn't ideal but it ensured that special keys were handled by the IME.

There's no IME start/end notification on macOS?

@danwalmsley @Gillibald

@Gillibald
Copy link
Contributor

Maybe we should just process the key-down event all the time? Will investigate.

@kekekeks
Copy link
Member

kekekeks commented Sep 2, 2023

If IME is in play user code should never get events that are processed by IME. Attempting to handle those is invalid behavior which needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants