Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix macos keydown and textinput events being raised in the wrong order. #12560

Merged
merged 2 commits into from
Aug 16, 2023
Merged

fix macos keydown and textinput events being raised in the wrong order. #12560

merged 2 commits into from
Aug 16, 2023

Conversation

danwalmsley
Copy link
Member

Current behavior:
MacOS:
TextInput
KeyDown
KeyUp

Windows / Linux / Expected behavior
KeyDown
TextInput
KeyUp

PR fixes the order.

@Gillibald to ensure IME still works etc.

Gillibald
Gillibald approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@Gillibald Gillibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Korean, Japanese and traditional Chinese

Everything still works

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038482-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@danwalmsley danwalmsley added this pull request to the merge queue Aug 16, 2023
Merged via the queue into master with commit 4f08bce Aug 16, 2023
5 checks passed
@danwalmsley danwalmsley deleted the fixes/macos-key-textinput-events-order branch August 16, 2023 19:01
@grokys grokys mentioned this pull request Aug 17, 2023
Merged
This was referenced Aug 17, 2023
Closed
Closed
@BAndysc BAndysc mentioned this pull request Sep 4, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gillibald Gillibald Gillibald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danwalmsley @avaloniaui-team @Gillibald