Improved handling of the input for TextPresenter #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var isShortCut = isShortcutKey && isControlPressed; | ||
|
|
||
| return !string.IsNullOrEmpty(e.Text) && !IsCharacterDeletionKey(e.Key) && !isShortCut; |
There was a problem hiding this comment.
Don't we already check for a deletion key in the main hey handler?
kekekeks
pushed a commit
that referenced
this pull request
Nov 15, 2018
Changed Theme Namespace to avoid conflict
maxkatz6
pushed a commit
that referenced
this pull request
Feb 20, 2023
* Fix attached properties resolution * Strip out controls that aren't IControl * Be more strict and check the namespace * Update packages, throw when class is not partial * Use internal access modifier explicitly * Move the attribute to Avalonia.Controls namespace * Further documentation updates * Add the badges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I fixed the problem where pressing the A key doesn't insert any text.
Please, note that I omitted the "this" keyword. This is much discussed, but I have researched to form an opinion on this coding style. Anyone that needs justification, please, contact me.
Thanks :)