Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build AOT demo project on CI #16108

Closed
wants to merge 6 commits into from
Closed

Build AOT demo project on CI #16108

wants to merge 6 commits into from

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

Not sure yet if it's the best way for us to test AOT builds on the CI.
Ideally, we should compile our unit tests with AOT and run them on CI instead.
But for now, building single project with all AOT/trimming errors enabled should be enough.
Continues #15815 (as well as this PR should prevent similar regressions).

What is the current behavior?

If any commit regresses AOT support, including AOT related warnings, nobody might notice until too late.

What is the updated/expected behavior with this PR?

If any commit regresses AOT support, including AOT related warnings, build should fail.

How was the solution implemented (if it's not obvious)?

Re-purposing BindingDemo project as a decent functionality test.

@maxkatz6 maxkatz6 added area-infrastructure Issues related to CI/tooling infrastructur area-trimming-aot labels Jun 24, 2024
@maxkatz6 maxkatz6 requested a review from kekekeks June 24, 2024 22:55
@maxkatz6 maxkatz6 changed the title Build AOT demo project on a CI Build AOT demo project on CI Jun 24, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049237-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049243-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050546-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6
Copy link
Member Author

Might not be necessary after #16543

@kekekeks
Copy link
Member

kekekeks commented Aug 1, 2024

Can we run some subset of integration tests with AOT too? e. g. ones that would cover bindings and stuff.

@maxkatz6
Copy link
Member Author

maxkatz6 commented Aug 1, 2024

@kekekeks once [GeneratedComInterface] is merged, I was considering to run full set of integrational tests with AOT. We don't rely on reflection there, it should work well.

@maxkatz6
Copy link
Member Author

maxkatz6 commented Oct 8, 2024

Closing, as we want to focus on integrational tests in AOT mode instead.

@maxkatz6 maxkatz6 closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Issues related to CI/tooling infrastructur area-trimming-aot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants