Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrayIcon integration tests #16154

Merged
merged 12 commits into from
Jul 8, 2024
Merged

TrayIcon integration tests #16154

merged 12 commits into from
Jul 8, 2024

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Jun 28, 2024 •
edited
Loading

What does the pull request do?

Continues #16024.
Before we didn't have any integration tests for tray icon. Now we have some:

  • Left mouse button click.
  • Context menu with menu item click.
  • Visibility toggle.

@avaloniaui-bot

This comment was marked as outdated.

Sign in to view
@maxkatz6
Copy link
Member Author

maxkatz6 commented Jun 28, 2024 •
edited
Loading

Good: added macOS tests.
Bad: it seems CI Windows machine doesn't have task bar to begin with, or we don't have access to it. Win10 had different accessibility names for the tray menu.

@maxkatz6 maxkatz6 changed the title [Windows] TrayIcon integration tests TrayIcon integration tests Jun 28, 2024
@avaloniaui-bot

This comment was marked as spam.

Sign in to view
@avaloniaui-bot

This comment was marked as spam.

Sign in to view
@avaloniaui-bot

This comment was marked as outdated.

Sign in to view
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049605-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 requested a review from grokys June 28, 2024 10:38
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049617-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049645-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@logiclrd
Copy link
Contributor

Nice! I've only had my Linux laptop to test on, did the crashes that #16024 fixed replicate on platforms other than Linux??

@maxkatz6
Copy link
Member Author

maxkatz6 commented Jul 8, 2024

@logiclrd no, I wasn't able to replicate any crashes on other platforms. But it's still better to have these tests, especially when we get Linux tests running as well.

@maxkatz6 maxkatz6 merged commit ad0bc0d into master Jul 8, 2024
11 checks passed
@maxkatz6 maxkatz6 deleted the tray-icon-e2d-tests branch July 8, 2024 23:44
@maxkatz6 maxkatz6 mentioned this pull request Jul 9, 2024
Merged
Gillibald pushed a commit to Gillibald/Avalonia that referenced this pull request Jul 29, 2024
@maxkatz6 @Gillibald
TrayIcon integration tests (AvaloniaUI#16154)
27ec6b3 
* Add accessibility ID to the TrayPopupRoot on Windows

* [Windows] Add left click and menu item click e2e tests for TrayIcon

* [Windows] Add TrayIcon visibility toggle tests

* Implement macOS tray icon tests

* Make it easier to read tray icon logs

* Try to handle win10 accessibility names

* Try to upload PageSource

* Set condition: always

* Hopefully, it works on CI

* Try to upload PageSource AvaloniaUI#2

* Fix win10, hopefully for the last time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokys grokys Awaiting requested review from grokys

Assignees
No one assigned
Labels
area-accessibility enhancement os-macos os-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxkatz6 @avaloniaui-bot @logiclrd