feat(Window): Allow to persist content of Clipboard after App close #16778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
workgroupengineering
force-pushed
the
feature/Clip_SetDataObject_Persistence
branch
from
fd72ec4
to
04b4e0c
Compare
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Sep 12, 2024
| /// <param name="data">A data object (an object that implements <see cref="IDataObject"/>) to place on the system Clipboard.</param> | ||
| /// <param name="copy"><c>true</c> to leave the data on the system Clipboard when the application exits; false to clear the data from the system Clipboard when the application exits.</param> | ||
| /// <exception cref="System.ArgumentNullException"><paramref name="data"/> is null.</exception> | ||
| Task SetDataObjectAsync(IDataObject data, bool copy); |
There was a problem hiding this comment.
I think correct API would be Clipboard.FlushAsync() which can be more reliably supported on other platforms without unnecessary throwing an exception.
Especially since we can't guarantee actual copying (or even less - not copying dataobject) on all platforms.
This reverts commit 04b4e0c.
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Add FlushAsync method
What is the current behavior?
It is not supported by any platform
What is the updated/expected behavior with this PR?
Permanently adds data to the Clipboard on the Windows platform, does nothing on other platforms.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Part of
#15411