Avoid Select when no boxing required #16886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Always instantiate an instance of
Selectobserver.What is the updated/expected behavior with this PR?
Don't create any
Selectif the binding value type is a reference type.Checklist
Breaking changes
Shouldn't but if the observable implements
IObservable<object>then this interface will be used instead of covariance.Alternative solutions
If we don't care about observables implementing
IObservable<object>differently thanIObservable<T>then the code can be rewritten to simply useascast and use the result. It can be helpful for smart observables handling boxing internally, but that I assume is pretty rare.